Complaints of errors in Xcode 4.3 with the NSCachedURLResponse category - #29
Open
samstewart wants to merge 5 commits into
Open
Complaints of errors in Xcode 4.3 with the NSCachedURLResponse category#29samstewart wants to merge 5 commits into
samstewart wants to merge 5 commits into
Conversation
…onse instead of NSCachedURLResponse category smashing
Author
|
After looking over diff a bit closer I noticed some company code. Let me isolate the fix first. |
Author
|
OK, removed the proprietary naming scheme so should be all ready to go. We included some other small fixes for code clarity, etc. |
Author
|
Re-added "lowercaseString" code in most recent commit |
Author
|
The recent commit fixes an error as described below: The removal of the NSCachedURLResponse category means that NSKeyedArchiver will throw an EXC_BAD_ACCESS when attempting to load NSCachedURLResponse data. This means that this change requires a cache refresh, and a new cache key namespace that will prevent this from happening. Old cache keys will eventually be evicted from the system as new keys are populated. |
rs
pushed a commit
that referenced
this pull request
May 11, 2012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Xcode 4.3, a warning message is raised because of the overridden methods in the category on NSCachedURLResponse.
More Info:
http://www.iphonedevsdk.com/forum/iphone-sdk-development/99057-new-xcode-4-3-compiler-warnings-categories.html
We've written a simple wrapper instead which conforms to the NSCoding and NSCopying protocols and does not use categories. From our limited testing the approach seems to work and alleviates the error.