fix: CI smoke test — use haproxy.cfg.template in Dockerfile - #3
Merged
Conversation
…gnored) The Dockerfile was copying haproxy.cfg which is gitignored and doesn't exist on fresh CI clones. Use haproxy.cfg.template (which is tracked) as the build source.
ronsilver
changed the title
check.torproject.org returns {"IsTor":true,...} without
space after colon, causing the grep '"IsTor": true' to fail.
Use 'IsTor:[ ]*true' pattern to match both 'IsTor:true' and 'IsTor: true' but reject false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Root cause: CI smoke test failed at
docker compose up -d --buildbecause the HAProxy Dockerfile copieshaproxy.cfgwhich is gitignored (generated file), but onlyhaproxy.cfg.templateis tracked in the repo. On fresh CI clones,haproxy.cfgdoesn't exist → Docker build fails.Fix: Updated
config/haproxy/Dockerfileto copyhaproxy.cfg.templateinstead. The template IS the config (no runtime variable substitution needed), so this is safe.Files changed
config/haproxy/Dockerfilehaproxy.cfg.template(tracked) instead ofhaproxy.cfg(gitignored)config/haproxy/haproxy.cfg.templateinfolog level +log-formatfor better debugging.gitignoredocs/resourcesanddocs/reports.github/workflows/test.yml