Skip to content
This repository was archived by the owner on Aug 12, 2019. It is now read-only.

User str instead of basestring - python 3 - #4

Open
kumy wants to merge 1 commit into
romain-dartigues:masterfrom
kumy:basestring
Open

User str instead of basestring - python 3#4
kumy wants to merge 1 commit into
romain-dartigues:masterfrom
kumy:basestring

Conversation

@kumy

@kumy kumy commented Nov 4, 2017

Copy link
Copy Markdown

Current code seems not compatible with python 3.

See https://stackoverflow.com/a/34803630/944936

@romain-dartigues romain-dartigues added this to the Python 3 milestone Aug 28, 2018
@romain-dartigues

Copy link
Copy Markdown
Owner

Actually the code is specific Python 2.5 - 2.7.

Unfortunately, the Python 3.x support requiert much more changes than just that.
Especially around how I used the bytearray which is really Python 2 specific.

I quickly attempted to patch here and there, but most of the python3 setup.py test still fail.
A "redo" must be done, if possible without using compatibility libraries such as six; maybe it will be the time to rewrite IHIH as a full FSM.

@romain-dartigues
romain-dartigues force-pushed the master branch 2 times, most recently from 4896f80 to c9ee71c Compare September 17, 2018 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants