fix(canary): delete the non-current split layer with plain run - #158
Merged
Conversation
…th plain run `navigate_to_output` requires `ez delete` to print a worktree path to cd into, which only happens when deleting the branch you are standing on. After `ez split`, the current branch is the top layer (`split-src`), so deleting the lower layer `split-src-1` prints nothing and the helper failed the canary — blocking the v0.3.4 release on a bug in the canary script, not in ez. The split itself ran correctly in that canary; only the cleanup was wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.4 release failed at the canary gate — on a bug in the canary script I added in #156, not in ez.
navigate_to_outputexpectsez deleteto print a worktree path to cd into, which only happens when you delete the branch you are currently standing on. Afterez split, the current branch is the top layer (split-src), so deleting the lower layersplit-src-1prints nothing and the helper treated that as a failure.ez splititself ran correctly in that canary run — create, two commits,--dry-run,split, andlogall passed against real GitHub. Only the cleanup line was wrong.Uses plain
runfor the non-current branch, with a comment explaining the distinction so the next person doesn't reach fornavigate_to_outputagain.