Skip to content

Replace fastssz with dynamic-ssz#1127

Open
0xfornax wants to merge 3 commits into
masterfrom
replace-fastssz-dynamicssz
Open

Replace fastssz with dynamic-ssz#1127
0xfornax wants to merge 3 commits into
masterfrom
replace-fastssz-dynamicssz

Conversation

@0xfornax

@0xfornax 0xfornax commented Jul 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@0xfornax 0xfornax closed this Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Coverage Report

@0xfornax 0xfornax reopened this Jul 9, 2026
@0xfornax 0xfornax marked this pull request as draft July 9, 2026 19:09
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Coverage Report

@0xfornax 0xfornax marked this pull request as ready for review July 15, 2026 22:37
@github-actions

Copy link
Copy Markdown

Coverage Report

@0xfornax 0xfornax force-pushed the replace-fastssz-dynamicssz branch from 6891a23 to efa2b1c Compare July 15, 2026 23:39
@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/shared/services 0.24% (ø)
github.com/rocket-pool/smartnode/shared/services/beacon 15.28% (ø)
github.com/rocket-pool/smartnode/shared/services/beacon/client 0.49% (-0.00%) 👎
github.com/rocket-pool/smartnode/shared/types/eth2 2.04% (+2.04%) 👍
github.com/rocket-pool/smartnode/shared/types/eth2/fork/deneb 5.45% (-0.39%) 👎
github.com/rocket-pool/smartnode/shared/types/eth2/fork/electra 0.00% (ø)
github.com/rocket-pool/smartnode/shared/types/eth2/fork/fulu 0.00% (ø)
github.com/rocket-pool/smartnode/shared/types/eth2/generic 2.08% (-0.69%) 👎
github.com/rocket-pool/smartnode/shared/utils/validator 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/shared/services/beacon/client.go 11.36% (ø) 132 15 117
github.com/rocket-pool/smartnode/shared/services/beacon/client/std-http-client.go 0.00% (ø) 7139 (+15) 0 7139 (+15)
github.com/rocket-pool/smartnode/shared/services/megapools.go 0.80% (ø) 6500 52 6448
github.com/rocket-pool/smartnode/shared/services/services.go 0.00% (ø) 2719 0 2719
github.com/rocket-pool/smartnode/shared/types/eth2/fork/deneb/block_deneb.go 8.85% (-0.88%) 226 20 (-2) 206 (+2) 👎
github.com/rocket-pool/smartnode/shared/types/eth2/fork/deneb/deneb_generated.go 5.51% (+5.51%) 41486 (+41486) 2286 (+2286) 39200 (+39200) 👍
github.com/rocket-pool/smartnode/shared/types/eth2/fork/deneb/state_deneb.go 3.17% (ø) 1418 45 1373
github.com/rocket-pool/smartnode/shared/types/eth2/fork/electra/block_electra.go 0.00% (ø) 226 0 226
github.com/rocket-pool/smartnode/shared/types/eth2/fork/electra/electra_generated.go 0.00% (ø) 57278 (+57278) 0 57278 (+57278)
github.com/rocket-pool/smartnode/shared/types/eth2/fork/electra/state_electra.go 0.00% (ø) 1468 0 1468
github.com/rocket-pool/smartnode/shared/types/eth2/fork/fulu/block_fulu.go 0.00% (ø) 226 0 226
github.com/rocket-pool/smartnode/shared/types/eth2/fork/fulu/fulu_generated.go 0.00% (ø) 57859 (+57859) 0 57859 (+57859)
github.com/rocket-pool/smartnode/shared/types/eth2/fork/fulu/state_fulu.go 0.00% (ø) 1608 0 1608
github.com/rocket-pool/smartnode/shared/types/eth2/generic/block.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/eth2/generic/dynssz.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/shared/types/eth2/generic/generic_generated.go 2.07% (+2.07%) 50357 (+50357) 1041 (+1041) 49316 (+49316) 👍
github.com/rocket-pool/smartnode/shared/types/eth2/types.go 2.04% (+2.04%) 589 (+15) 12 (+12) 577 (+3) 👍
github.com/rocket-pool/smartnode/shared/utils/validator/deposit-data.go 0.00% (ø) 187 0 187
github.com/rocket-pool/smartnode/shared/utils/validator/set-withdrawal-creds.go 0.00% (ø) 306 0 306
github.com/rocket-pool/smartnode/shared/utils/validator/voluntary-exit.go 0.00% (ø) 194 0 194

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/rocket-pool/smartnode/shared/types/eth2/proofs_test.go
  • github.com/rocket-pool/smartnode/shared/types/eth2/streaming_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant