Fix handling of holding register dump #198 - #225
Open
super-sonic-zero wants to merge 3 commits into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
super-sonic-zero
marked this pull request as ready for review
August 10, 2026 18:27
super-sonic-zero
marked this pull request as draft
August 10, 2026 18:35
Contributor
Author
|
Marked as draft again as I got a one warning in my log: [WARNING] Parsing GrowattModbusBlock: |
super-sonic-zero
marked this pull request as ready for review
August 15, 2026 06:29
Contributor
Author
|
The warning I got seemed to be related to other unknown message types. The "Unknown msg_type" output is tied to debug level "debug" so I don't normally see this message on debug level "info". I changed it locally for me from "debug" to "warning" and got this: 2026-08-14 11:51:18,042 [WARNING] Parsing GrowattModbusBlock: 2026-08-14 11:51:18,042 [WARNING] Unknown msg_type 262:... |
Owner
|
I take a look 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for parsing the holding register dump that is send every hour (#198)