fix(review): add build and test execution step to /review skill - #16
Merged
Conversation
The /review skill listed "not running tests" as a gotcha but never included an actual step to run the build and tests. This adds Step 3 (Run build and tests) between the review checklist and the review output, and updates the /sdd orchestrator Phase 5 gate to require passing build and tests. https://claude.ai/code/session_01LDHJVEHYbDLP22npggJCKq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/reviewskill listed "not running tests" as a gotcha but never included an actual step to run the build and tests/sddorchestrator Phase 5 gate to require passing build and tests before proceeding to shipChanges
skills/review/SKILL.md: Added Step 3 (Run build and tests) with build/test discovery and execution instructions; updated review output template with Build/Tests fields; renumbered Step 3 → Step 4skills/sdd/SKILL.md: Updated Phase 5 gate to include build and test verification in the completion checklistHow to test
/reviewon a project with tests — verify it now runs build and tests as part of the review/sddend-to-end — verify Phase 5 gate reports build/test statushttps://claude.ai/code/session_01LDHJVEHYbDLP22npggJCKq