fix(skills): address field report findings from issue #13 - #15
Merged
Conversation
- /implement: add explicit discovery of ALL test suites (unit, integration, functional) and instruction to inform user when infrastructure-dependent tests cannot be run - /review: add test coverage checklist (new behavior → test, validation → positive+negative test) and gotcha about only running unit tests - /ship: add English enforcement rule for commits/PR titles/bodies, add multi-repo safety (verify remote before push), add related gotchas Closes #13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/implement: Add explicit discovery of ALL test suites (unit, integration, functional) and instruction to inform the user when infrastructure-dependent tests cannot be run/review: Add test coverage checklist (new behavior → test, validation → positive+negative test) and gotcha about only running unit tests/ship: Add English enforcement rule for commits/PR titles/bodies, add multi-repo safety (verify remote before push), and related gotchasContext
Issue #13 is a field report from using the full
/sddpipeline on a cross-repo feature. It identified 5 improvement areas. Analysis showed that 2 were already addressed (/tasksEnglish enforcement and immediate branch push) and 1 was partially covered (/implementTDD for behavior changes). The remaining gaps were:/shiphad no English enforcement for commits and PR content/implementand/reviewsaid "full test suite" but didn't instruct to discover all test projects or handle infra-dependent suites/reviewlacked a test coverage checklist/shiphad no multi-repo remote verification before pushChanges
skills/implement/SKILL.md: Step 2 now instructs to discover all test suites, run each one, and inform user about infra-dependent tests that can't be runskills/review/SKILL.md: Added 3 checklist items for test coverage (new behavior, validation rules, changed code paths) and a new gotcha about only running unit testsskills/ship/SKILL.md: Added language rule for English enforcement, added Step 4 remote verification for multi-repo safety, added 2 new gotchasHow to test
Closes #13