feat(clr): add ClojureCLR support - #70
Merged
Merged
Conversation
Convert sources and tests to .cljc with :cljr reader conditionals so the library compiles and runs on ClojureCLR, alongside the existing JVM and ClojureScript targets. Host-interop only (IDisposable over Closeable, namespace-qualified interface methods, System.* types); public API unchanged. Co-authored-by: 洪 恒 <hongheng@users.noreply.github.com>
Add deps-clr.edn (the cljr-preferred deps file) with a test alias on dmiller/test-runner, wire a clr-test step into build.clj so clojure -T:build ci runs the CLR suite alongside clj and cljs, and install ClojureCLR in the workflow.
Owner
|
Very good! Thanks. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 75.82% 75.47% -0.36%
==========================================
Files 5 5
Lines 211 261 +50
Branches 14 14
==========================================
+ Hits 160 197 +37
- Misses 37 50 +13
Partials 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
:cljrbranches for host interop (System.IDisposable/.Dispose,System.*types).deps-clr.edn(dmiller/test-runner) and aclr-testtask inbuild.clj, soclojure -T:build ciruns the CLR suite alongside clj and cljs.