Skip to content

fix(diarychat): move base path to /api/v1/diary-chatrooms (Spring ambiguous mapping startup fix) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rivkode wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(diarychat): move base path to /api/v1/diary-chatrooms (Spring ambiguous mapping startup fix) #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/prd/backend_api_request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,7 @@ Screen 3은 **"각자 녹음 → STT → 텍스트로 합류하는 음성 기반

### 7.0.1 구현 메모 / spec 대비 diff

- **베이스 path 변경 (필수)** — spec 의 `/chatrooms` 는 기존 페르소나 채팅 도메인(`ChatRoomApiController`, `/api/v1/chatrooms`)이 이미 사용 중이라 충돌. **본 도메인은 `/api/v1/diary-chatrooms`** 로 마운트한다. 즉 `POST /api/v1/diary-chatrooms`, `GET /api/v1/diary-chatrooms/{roomId}`, `.../messages`, `.../messages/poll` 등 spec 의 모든 `/chatrooms/...` 를 `/diary-chatrooms/...` 로 치환.
- **events 저장 모델 (구현 변경)** — spec은 events 를 별도 데이터로 다루지만, 단일 `after={messageId}` cursor 정합성을 위해 백엔드 내부에서는 `diary_chat_message` 테이블에 `source='system' + event_type` 형태로 함께 저장한다. 폴링 응답 시 `source` 로 분리해서 `items` / `events` 두 필드로 변환. **응답 shape 은 spec 그대로**.
- **AI 토글 기본값** — spec은 `aiAssistantEnabled` 기본 false. 사용자(=PRD owner) 결정으로 **default true** 로 변경 (방 생성 시 자동 ON). 방장이 끌 수 있음.
- **AI 식별자** — `author.userId = -1`, `username = "Jamo AI"` 합성 author 로 응답 (별도 필드 없이 author 객체에 담김).
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/com/learner/language/interfaces/diarychat/DiaryChatMessageController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import org.springframework.web.bind.annotation.RequestParam
import org.springframework.web.bind.annotation.RestController

@RestController
@RequestMapping("/api/v1/chatrooms/{roomId}/messages")
@RequestMapping("/api/v1/diary-chatrooms/{roomId}/messages")
class DiaryChatMessageController(
private val facade: DiaryChatMessageFacade,
) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/com/learner/language/interfaces/diarychat/DiaryChatPollingController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import org.springframework.web.bind.annotation.RestController
import org.springframework.web.context.request.async.DeferredResult

@RestController
@RequestMapping("/api/v1/chatrooms/{roomId}/messages")
@RequestMapping("/api/v1/diary-chatrooms/{roomId}/messages")
class DiaryChatPollingController(
private val facade: DiaryChatPollingFacade,
) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/com/learner/language/interfaces/diarychat/DiaryChatRoomController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import org.springframework.web.bind.annotation.RequestMapping
import org.springframework.web.bind.annotation.RestController

@RestController
@RequestMapping("/api/v1/chatrooms")
@RequestMapping("/api/v1/diary-chatrooms")
class DiaryChatRoomController(
private val facade: DiaryChatRoomFacade,
) {
Expand Down