Skip to content

[IGNORE] Cumulative changes from facts rewrite - #260

Open
zoogies wants to merge 16 commits into
mainfrom
review/reach-rust-stack
Open

[IGNORE] Cumulative changes from facts rewrite#260
zoogies wants to merge 16 commits into
mainfrom
review/reach-rust-stack

Conversation

@zoogies

@zoogies zoogies commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

This is a branch with all of the stack PR changes combined into one PR, in case this is easier 😄

@zoogies zoogies self-assigned this Aug 20, 2026
@zoogies
zoogies force-pushed the review/reach-rust-stack branch from f9d97a8 to f5fcb77 Compare August 20, 2026 14:11
Comment thread docs/components/reach.md
files, which is determined by the [**RESOLVE** LLVM
pass](https://github.com/riversideresearch/resolve/blob/main/resolve-cc/src/ResolveFactsPluginPass.cpp)
that generates the facts.
Use `--dynlink` to include compatible external-linkage functions as indirect-call targets.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear yet when I should use dynlink and what it does?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a custom flag (I think -dl) from eval 2 (CFS) that reach wrapper used to forward as a pass-through arg to reach. Just turns on indirect edges

Comment thread docs/components/reach.md
If you omit `--output`, the command derives the path from the input name. For example, `vulnerabilities.json` produces `vulnerabilities.reach.json`.

See the `--help` output for command line arguments/options.
Use `--src` to read a package version from a Vcpkg manifest. The result becomes unreachable when the installed version is outside the vulnerable range.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to make this more generic and support sboms generally? Including those generated by cmake...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants