facts: add multi-file binary reader - #253
Open
zoogies wants to merge 1 commit into
Open
Conversation
zoogies
force-pushed
the
feat/facts-reader
branch
from
August 18, 2026 17:47
d8998db to
f343797
Compare
zoogies
marked this pull request as ready for review
August 20, 2026 13:39
zoogies
force-pushed
the
feat/facts-reader
branch
from
August 20, 2026 14:11
f343797 to
416438e
Compare
rjsmith1999
reviewed
Sep 3, 2026
Comment on lines
+102
to
+106
| pub extern "C" fn facts_module_next( | ||
| facts: *const FactsBuf, | ||
| cursor: *mut FactsModuleCursor, | ||
| output: *mut FactsModuleView, | ||
| ) -> bool { |
Collaborator
There was a problem hiding this comment.
One pattern you could use here: create a safe 'inner' function that handles all of the rust logic. It could return an option, so you could use ? in place of let else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬