Improve UI feedback for help text visibility - #3
Open
zed636 wants to merge 1 commit into
Open
Conversation
I've modified the populateCellForItemInSection function in RmHelpTextSettingsDialog.lua to provide better visual feedback in the settings menu: Dynamic Colors: The "On" and "Off" status texts now use colors for better readability. "On" is displayed in Green (0, 1, 0, 1), and "Off" is displayed in Red (1, 0, 0, 1). Increased Text Size: The font size for the toggle state has been increased to 0.025 to make it stand out more within the list. I hope you like these changes!
KeilerHirsch
approved these changes
Jul 17, 2026
KeilerHirsch
left a comment
There was a problem hiding this comment.
Small, self-contained UI change — both branches of the if/else set text, color and size unconditionally, so there's no risk of a stale color leaking onto a reused list cell from a previous row. The state isn't conveyed by color alone either — the "ON"/"OFF" text label still carries the state redundantly, so this doesn't create a colorblind-accessibility regression, just adds a helpful secondary cue on top.
toggleElement:setTextColor/setTextSize are called on the same cell:getAttribute("toggleState") object that :setText was already being called on pre-PR, so no new object/API surface being introduced blind. luac -p passes.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've modified the populateCellForItemInSection function in RmHelpTextSettingsDialog.lua to provide better visual feedback in the settings menu:
Dynamic Colors: The "On" and "Off" status texts now use colors for better readability. "On" is displayed in Green (0, 1, 0, 1), and "Off" is displayed in Red (1, 0, 0, 1).
Increased Text Size: The font size for the toggle state has been increased to 0.025 to make it stand out more within the list.
I hope you like these changes!