Skip to content

Improve UI feedback for help text visibility - #3

Open
zed636 wants to merge 1 commit into
rittermod:mainfrom
zed636:patch-1
Open

Improve UI feedback for help text visibility#3
zed636 wants to merge 1 commit into
rittermod:mainfrom
zed636:patch-1

Conversation

@zed636

@zed636 zed636 commented Jan 24, 2026

Copy link
Copy Markdown

I've modified the populateCellForItemInSection function in RmHelpTextSettingsDialog.lua to provide better visual feedback in the settings menu:

Dynamic Colors: The "On" and "Off" status texts now use colors for better readability. "On" is displayed in Green (0, 1, 0, 1), and "Off" is displayed in Red (1, 0, 0, 1).

Increased Text Size: The font size for the toggle state has been increased to 0.025 to make it stand out more within the list.

I hope you like these changes!

I've modified the populateCellForItemInSection function in RmHelpTextSettingsDialog.lua to provide better visual feedback in the settings menu:

Dynamic Colors: The "On" and "Off" status texts now use colors for better readability. "On" is displayed in Green (0, 1, 0, 1), and "Off" is displayed in Red (1, 0, 0, 1).

Increased Text Size: The font size for the toggle state has been increased to 0.025 to make it stand out more within the list.

I hope you like these changes!
@rittermod rittermod self-assigned this Feb 3, 2026
@rittermod rittermod added the Enhancement New feature or request label Feb 3, 2026

@KeilerHirsch KeilerHirsch left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, self-contained UI change — both branches of the if/else set text, color and size unconditionally, so there's no risk of a stale color leaking onto a reused list cell from a previous row. The state isn't conveyed by color alone either — the "ON"/"OFF" text label still carries the state redundantly, so this doesn't create a colorblind-accessibility regression, just adds a helpful secondary cue on top.

toggleElement:setTextColor/setTextSize are called on the same cell:getAttribute("toggleState") object that :setText was already being called on pre-PR, so no new object/API surface being introduced blind. luac -p passes.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants