Keep multiplayer settings under server control - #26
Open
user01010111 wants to merge 1 commit into
Open
Conversation
user01010111
marked this pull request as ready for review
July 29, 2026 05:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary multiplayer clients could change the shared settings from the game settings page. The server rejected those events, but the client had already changed its local state and did not receive the accepted values back. This could leave shortcut visibility, mass scaling, or speed scaling different on that client.
This makes the three shared controls read-only for non-admin multiplayer clients and prevents their callbacks from changing local state. If an unauthorized settings event still reaches the server, the server now returns its current settings to that connection without broadcasting the rejected change.
Single-player, server-host, and remote-admin behavior is unchanged.
Tested with Lua syntax checks, XML validation, and local multiplayer checks covering UI permissions, rejected callbacks, accepted admin changes, server rejection, corrective serialization, and broadcast behavior.
This has not been tested in a live multiplayer session.