Skip to content

Refresh vehicle speed and mass after capacity changes - #24

Open
user01010111 wants to merge 1 commit into
rittermod:mainfrom
user01010111:agent/fix-vehicle-runtime-scaling
Open

Refresh vehicle speed and mass after capacity changes#24
user01010111 wants to merge 1 commit into
rittermod:mainfrom
user01010111:agent/fix-vehicle-runtime-scaling

Conversation

@user01010111

Copy link
Copy Markdown

Changing a vehicle’s capacity at runtime updated the fill unit, but the follow-up discharge-speed check looked for applyProportionalDischargeSpeed on the specialization data table. That table only contains per-vehicle state, so the check always failed. Discharge speed was not updated until another path reapplied it, such as reloading the vehicle or toggling the setting.

Capacity changes also left the cached component mass unchanged until another fill operation marked it dirty.

This calls the existing discharge-speed helper whenever the vehicle has the specialization and marks component mass dirty after applying a capacity change. The existing original capacity and speed values remain the baseline, so repeated changes do not compound.

Tested with Lua syntax checks, XML validation, and local checks covering repeated capacity changes, discharge-speed scaling, reset behavior, mass invalidation, and mass scaling.

This has not been tested in a live game session.

@user01010111
user01010111 marked this pull request as ready for review July 29, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant