You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed. actions/checkout@v4 → @v5 (plus actions/cache/restore and save where present), which is the Node 24 migration — Node 20 is deprecated on the runners and already emits a warning on every job in this org.
Mechanical and correct. One thing worth recording, since it was not obvious from the diff.
The workflow rewrite and this bump do not collide
tag-release.yml in the protocol crates was rewritten wholesale a day ago to adopt the pull-request dev bump, and that rewrite kept checkout@v4. A clean merge does not tell you which side of an overlapping edit survived, so I performed the merge locally and looked at the result:
merged tag-release.yml:
20: - uses: actions/checkout@v5 <- this PR
...
gh pr create \ <- the workflow rewrite
Both survive. Git resolved it correctly because the rewrite left that line untouched relative to the base, so only one side had modified it. No action needed — but it was worth confirming rather than assuming, since the alternative would have been silently reverting one of the two.
No concerns. Good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutfrom v4 to v5This action major updates its runtime from Node 20 to Node 24. Self-hosted runners must be v2.327.1 or later.
Validation
actions/setup-nodeor project Node version declarations existgit diff --check