build(deps): override esbuild so the last dependabot alert closes - #346
Merged
Conversation
vite accepts esbuild 0.28 but pnpm will not cross a 0.x minor for a transitive peer on its own. With the override vite's optional peer drops out of the tree entirely; vite 8 and vitest 4 no longer need it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟢 Approval recommended
The override is scoped and the lockfile update consistently reflects the intended removal of the prior esbuild@0.27.7 resolution.
Pull request overview
This PR addresses a remaining Dependabot alert by adding a pnpm.overrides rule for esbuild and regenerating the pnpm lockfile so the dependency graph no longer pulls in the previously-resolved esbuild@0.27.7 optional peer for the Vite/Vitest toolchain.
Changes:
- Added
pnpm.overrides.esbuild: ^0.28.1topackage.json. - Updated
pnpm-lock.yamlto record the override and reflect the resulting dependency graph (removingesbuild@0.27.7and its platform-specific packages from the lock).
File summaries
| File | Description |
|---|---|
| package.json | Adds the pnpm override configuration for esbuild. |
| pnpm-lock.yaml | Captures the override in the lockfile and removes the previously-installed esbuild@0.27.7 entries from the resolved tree. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pnpm.overridesentry foresbuild: ^0.28.1. vite already accepts 0.28, but pnpm will not move a transitive peer across a 0.x minor by itself. With the override the optional peer is no longer installed at all; vite 8 and vitest 4 do not need it.pnpm audit: clean. npm never installed esbuild, sopackage-lock.jsonis unchanged.Verified:
pnpm lint,pnpm typecheck,pnpm test,pnpm build.