Ensure stable responsive width for Accordion and safe Button links - #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two user-facing improvements to the
jaci-uipackage: it enhances the accessibility and server compatibility of Button links, and improves the responsive behavior of Accordions. Additionally, it includes supporting documentation and code updates to reflect these changes. The most significant updates are outlined below.Button Link Improvements:
Buttoncomponent to allow safe rendering as a link (<a>) from Next.js server components. The implementation ensures that when a Button is rendered as an anchor, it does not attach client-only event handlers during server render, and disables the link appropriately when needed. This improves server compatibility and accessibility for Button links. (packages/ui/src/components/button/button.tsx,.changeset/bright-buttons-link.md,fixtures/next/app/page.tsx,packages/ui/README.md) [1] [2] [3] [4] [5] [6]Accordion Responsive Behavior:
.changeset/fresh-accordions-grow.md,apps/storybook/src/accordion.stories.tsx) [1] [2] [3]Supporting Documentation and Maintenance:
packages/ui/README.md,fixtures/next/app/page.tsx) [1] [2]docs/api-contract/0.9.0.jsonfile for consistency, expanding single-line arrays to multi-line format for better readability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]packages/ui/scripts/verify-client-boundaries.mjs,docs/api-contract/0.9.0.json) [1] [2]