Skip to content

Wip/matt auld/oa 4.4 dynamic testing#7

Open
matt-auld wants to merge 2 commits into
rib:wip/rib/oa-4.4-testingfrom
matt-auld:wip/matt-auld/oa-4.4-dynamic-testing
Open

Wip/matt auld/oa 4.4 dynamic testing#7
matt-auld wants to merge 2 commits into
rib:wip/rib/oa-4.4-testingfrom
matt-auld:wip/matt-auld/oa-4.4-dynamic-testing

Conversation

@matt-auld

Copy link
Copy Markdown

Feel free to take a look when you get the time. Thanks.

As per your comments:

  • We now silently fail when given an empty OA register set
  • We now check that at least one register set is given, be it MUX, BOOL or FLEX
  • We now explicitly check the uuid format from user-space - this is still just treated as a string and not a 128bit value
    • I did look into using the 128bit form for the uuid, but I couldn't find any helpful kernel utilities, other than this https://lwn.net/Articles/356868/. Something like uuid_unparse would be really nice here.
  • We now check for a uuid collision early on
  • We now return from the icotl the metric-set id, rather than storing it in the user struct - much cleaner

I think some kind of locking is still needed.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant