Skip to content

Minor fixes - #1349

Open
jaykim1213 wants to merge 26 commits into
devfrom
jay/minorConfigFixes
Open

Minor fixes#1349
jaykim1213 wants to merge 26 commits into
devfrom
jay/minorConfigFixes

Conversation

@jaykim1213

@jaykim1213 jaykim1213 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Give a longer description of what this PR addresses and why it's needed

This PR fixes response handling, UI spacing, validation, study content, unused assets, and test organization across demo, example, library, and test studies.

demo-html-input

Reduced the gap between the bar chart and the response.

Before

demo-html-input before

After

demo-html-input after

demo-form-elements

  • Added validation when the confidence value exceeds 100.
  • Reduced the number of sidebar Likert items to prevent overflow.
  • Corrected form labels, prompts, and default-value examples.

After

confidence value validation

demo-choropleth-map

Required participants to select exactly three states before continuing and corrected the task instructions.

demo-vega

  • Assigned unique response IDs to the second Vega demo.
  • Removed an unused data file.
  • Corrected the instructions, description, and Vega-Lite capitalization.

Other demo studies

Corrected text, metadata, obsolete parameters, and invalid asset references in:

  • demo-condition
  • demo-dynamic
  • demo-html
  • demo-image
  • demo-ranking-widget
  • demo-react-trrack
  • demo-screen-recording
  • demo-training
  • demo-upset
  • demo-video
  • demo-yaml

example-VLAT-adaptive

  • Improved empty and missing-answer handling in feedback views.
  • Added fallbacks for missing questions and trials.
  • Improved visualization alt text.
  • Corrected the documented VLAT question count and removed an unused consent file.

example-brush-interactions

  • Improved cleanup of debounced callbacks and brush event listeners.
  • Prevented null brush selections from being processed.
  • Corrected task wording and response labels.
  • Removed unused help and data files.

example-cleveland

Corrected study text and fixed the stacked bar chart height value.

example-llm-chatbot

  • Added a note explaining the proxy and allowed-origin requirements.
  • Corrected the Trrack action name used for message updates.
  • Improved setup instructions.

example-mvnv

  • Added requiredValue: "Accept" so participants can continue only after accepting the consent.
  • Corrected task instructions, descriptions, HTML, and documentation paths.
  • Updated answer posting to support both array and scalar answers.
  • Replaced unsafe task-number parsing and handled task number 0 correctly.

test-randomization

Moved the Next button below the stimulus and removed the duplicated introduction page.

Before

test-randomization with the Next button above the stimulus

After

test-randomization with the Next button below the stimulus

test-step-logic

Removed unused components, assets, and an unrelated correctAnswer.

Other test studies

Corrected titles, descriptions, labels, formatting, and obsolete references in:

  • test-audio
  • test-device-restriction
  • test-library
  • test-likert-matrix
  • test-parser-errors
  • test-skip-logic

The intentionally invalid parser fixtures remain unchanged in behavior.

library-previs and library-beauvis

Added a small margin between the charts and questions.

Before

PREVis before adding spacing

After

PREVis after adding spacing

Documentation and tests

  • Corrected repository and study documentation links and wording.
  • Moved existing unit tests into sibling tests/ directories.
  • Updated the affected E2E tests.

@jaykim1213
jaykim1213 changed the base branch from main to dev July 28, 2026 03:07
@jaykim1213
jaykim1213 force-pushed the jay/minorConfigFixes branch from 5f8f23d to 3b354c4 Compare July 28, 2026 04:28
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

A preview of 140d3d5 is uploaded and can be seen here:

https://revisit.dev/study/PR1349

Changes may take a few minutes to propagate.

@jaykim1213
jaykim1213 marked this pull request as ready for review July 28, 2026 06:51
@jaykim1213
jaykim1213 marked this pull request as draft July 28, 2026 08:37
@JackWilb

Copy link
Copy Markdown
Contributor

Reduced 7 response options to 6 to prevent overflowing

Likert scales usually have odd number of options so 5 is better

allowing zero dots caused the response UI to break

Probably this is an issue with truthyness. We should fix this properly instead of forcing 1.

@JackWilb JackWilb linked an issue Jul 30, 2026 that may be closed by this pull request
@jaykim1213
jaykim1213 marked this pull request as ready for review July 30, 2026 05:30
@jaykim1213
jaykim1213 requested a review from JackWilb July 30, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace demo-style React example

2 participants