Add filterCallback to EntityCollectionMappingFilter and EntityMapping - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added support for custom existing-entity resolution in
EntityMappingFilterandEntityCollectionMappingFilter.Both filters now accept an optional
filterCallback. It can be used to define customlookup logic, for example resolving an entity by
uuid. If the callback is not providedor does not return an entity, the previous
id-based lookup behavior is preserved.Details
filterCallbackconstructor argument toEntityMappingFilter.filterCallbackconstructor argument toEntityCollectionMappingFilterand pass it to the inner
EntityMappingFilter.id:idis present, the previous behavior is used;filterCallbackand usesits
getId().idlookup behavior with a regression test.tests/Utils.Why
This allows
EntityCollectionMappingFilterto support inputs identified by externalidentifiers such as
uuid, while keeping backward compatibility with the existingid-based mapping behavior.