Skip to content

chore: remove odos zap provider references - #1071

Merged
jgalat merged 2 commits into
masterfrom
chore/remove-odos
Jul 31, 2026
Merged

chore: remove odos zap provider references#1071
jgalat merged 2 commits into
masterfrom
chore/remove-odos

Conversation

@jgalat

@jgalat jgalat commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Companion to react-zapper 2.8.0 (Odos removal — their API returned HTTP 410 "Service Ended").

  • Removes the module-level PROVIDER_ENABLED[bsc.id].odos = false mutation in zapper-wrapper.tsx
    (the property no longer exists in 2.8.0 and would be a compile error after the bump).
  • Deletes the dead commented return 'odos' quote-source block and its unused
    DTF_DISABLED_FOR_ZAP constant.
  • Drops odos from the e2e aggregator mocks and updates wiki/docs (price consensus is 6 sources
    now that reserve-api dropped the odos label).

Follow-up on this branch after react-zapper 2.8.0 is on npm: bump
"@reserve-protocol/react-zapper" to "2.8.0" in package.json + pnpm install, commit as
chore: bump react-zapper to 2.8.0. The code here is forward-compatible with the current 2.7.1
pin, so CI stays green in the meantime.

Supersedes the open devin/1784922531-bump-react-zapper-2.7.2 bump branch.

Verification: pnpm typecheck (app + e2e tsconfigs) clean, pnpm lint no new warnings,
pnpm test:run 840 passed, pnpm e2e:smoke 56 passed / 1 pre-existing skip.

Summary by CodeRabbit

  • Changes

    • Price consensus now uses six sources, with Odos removed.
    • Zapper quotes now use native swaps, Velora, and Enso aggregators.
    • Odos is no longer available as a quote provider for documented zap flows.
    • Quote selection remains set to “best,” with existing caching, slippage, and minimum-output behavior unchanged.
  • Documentation

    • Updated Zapper and data-source documentation to reflect the revised provider configuration.
    • Updated testing guidance for exact quote amounts in zap mocks.

Odos discontinued their API; react-zapper 2.8.0 drops the provider. Removes the PROVIDER_ENABLED BSC mutation, dead quote-source code, and e2e/docs references ahead of the 2.8.0 bump.
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8ae62980-9aa1-4997-8768-73cfe63d54c2

📥 Commits

Reviewing files that changed from the base of the PR and between c890e5a and 818bc5d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

Odos is removed from Index DTF zapper configuration, aggregator mocks, and provider documentation. The zapper wrapper no longer mutates BSC provider settings, the quote-source atom remains fixed to best, and mock instructions require the exact pinned amountIn.

Changes

Index DTF zapper provider updates

Layer / File(s) Summary
Simplify runtime zapper configuration
package.json, src/views/index-dtf/components/zapper/zapper-wrapper.tsx, src/views/index-dtf/issuance/index.tsx
The dependency updates to @reserve-protocol/react-zapper 2.8.0. The wrapper no longer mutates PROVIDER_ENABLED for BSC. The quote-source atom uses a parameterless initializer returning the fixed default source.
Align mocks and documentation
e2e/helpers/zapper.ts, docs/wiki/zapper.md, docs/data-sources.md, src/views/index-dtf/issuance/CLAUDE.md
Odos is removed from mocked aggregator routes and provider descriptions. Price consensus lists six sources. Zap-surface mocks must use the exact pinned amountIn.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: lcamargof

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing Odos provider references across code, tests, documentation, and configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-odos

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/views/index-dtf/components/zapper/zapper-wrapper.tsx`:
- Line 2: Before removing Odos routing or updating the related flow, bump
`@reserve-protocol/react-zapper` from 2.7.1 to 2.8.0 in package.json and
pnpm-lock.yaml. Keep the existing Odos guard and mock coverage in
zapper-wrapper.tsx and e2e/helpers/zapper.ts, along with the provider
descriptions in docs/wiki/zapper.md and issuance/CLAUDE.md, aligned with the
installed provider set until that dependency bump is included; apply the
required updates at src/views/index-dtf/components/zapper/zapper-wrapper.tsx
(lines 2 and 20-21), e2e/helpers/zapper.ts (lines 16 and 139),
docs/wiki/zapper.md (lines 13-19), and src/views/index-dtf/issuance/CLAUDE.md
(lines 46-48).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 95cae33b-0cfc-411a-8b4b-49ad51d3162c

📥 Commits

Reviewing files that changed from the base of the PR and between fe18f8f and c890e5a.

📒 Files selected for processing (6)
  • docs/data-sources.md
  • docs/wiki/zapper.md
  • e2e/helpers/zapper.ts
  • src/views/index-dtf/components/zapper/zapper-wrapper.tsx
  • src/views/index-dtf/issuance/CLAUDE.md
  • src/views/index-dtf/issuance/index.tsx

Comment thread src/views/index-dtf/components/zapper/zapper-wrapper.tsx
lcamargof
lcamargof previously approved these changes Jul 30, 2026

@lcamargof lcamargof left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 31, 2026

Copy link
Copy Markdown

Deploying register-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 818bc5d
Status: ✅  Deploy successful!
Preview URL: https://7831d602.register-app.pages.dev
Branch Preview URL: https://chore-remove-odos.register-app.pages.dev

View logs

@jgalat
jgalat merged commit d0427a7 into master Jul 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants