chore: remove odos zap provider references - #1071
Conversation
Odos discontinued their API; react-zapper 2.8.0 drops the provider. Removes the PROVIDER_ENABLED BSC mutation, dead quote-source code, and e2e/docs references ahead of the 2.8.0 bump.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughOdos is removed from Index DTF zapper configuration, aggregator mocks, and provider documentation. The zapper wrapper no longer mutates BSC provider settings, the quote-source atom remains fixed to ChangesIndex DTF zapper provider updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/views/index-dtf/components/zapper/zapper-wrapper.tsx`:
- Line 2: Before removing Odos routing or updating the related flow, bump
`@reserve-protocol/react-zapper` from 2.7.1 to 2.8.0 in package.json and
pnpm-lock.yaml. Keep the existing Odos guard and mock coverage in
zapper-wrapper.tsx and e2e/helpers/zapper.ts, along with the provider
descriptions in docs/wiki/zapper.md and issuance/CLAUDE.md, aligned with the
installed provider set until that dependency bump is included; apply the
required updates at src/views/index-dtf/components/zapper/zapper-wrapper.tsx
(lines 2 and 20-21), e2e/helpers/zapper.ts (lines 16 and 139),
docs/wiki/zapper.md (lines 13-19), and src/views/index-dtf/issuance/CLAUDE.md
(lines 46-48).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 95cae33b-0cfc-411a-8b4b-49ad51d3162c
📒 Files selected for processing (6)
docs/data-sources.mddocs/wiki/zapper.mde2e/helpers/zapper.tssrc/views/index-dtf/components/zapper/zapper-wrapper.tsxsrc/views/index-dtf/issuance/CLAUDE.mdsrc/views/index-dtf/issuance/index.tsx
Deploying register-app with
|
| Latest commit: |
818bc5d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7831d602.register-app.pages.dev |
| Branch Preview URL: | https://chore-remove-odos.register-app.pages.dev |
Companion to react-zapper 2.8.0 (Odos removal — their API returned HTTP 410 "Service Ended").
PROVIDER_ENABLED[bsc.id].odos = falsemutation inzapper-wrapper.tsx(the property no longer exists in 2.8.0 and would be a compile error after the bump).
return 'odos'quote-source block and its unusedDTF_DISABLED_FOR_ZAPconstant.odosfrom the e2e aggregator mocks and updates wiki/docs (price consensus is 6 sourcesnow that reserve-api dropped the odos label).
Follow-up on this branch after react-zapper 2.8.0 is on npm: bump
"@reserve-protocol/react-zapper"to"2.8.0"in package.json +pnpm install, commit aschore: bump react-zapper to 2.8.0. The code here is forward-compatible with the current 2.7.1pin, so CI stays green in the meantime.
Supersedes the open
devin/1784922531-bump-react-zapper-2.7.2bump branch.Verification:
pnpm typecheck(app + e2e tsconfigs) clean,pnpm lintno new warnings,pnpm test:run840 passed,pnpm e2e:smoke56 passed / 1 pre-existing skip.Summary by CodeRabbit
Changes
Documentation