Skip to content

perf(Extraction): Extract more primitive integer operations efficiently - #240

Merged
tperami merged 1 commit into
mainfrom
perf-extraction-int
Sep 8, 2026
Merged

perf(Extraction): Extract more primitive integer operations efficiently#240
tperami merged 1 commit into
mainfrom
perf-extraction-int

Conversation

@tperami

@tperami tperami commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Comment thread Extraction/ZO.ml
let div2_pos z = if z == one then one else div2 z

let testbitZ a n =
let n = to_int n in

@febyeji febyeji Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can raise Overflow; but since n is a bit index, this should be okay?

@febyeji febyeji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit comment. Otherwise, it looks good to me.

@tperami
tperami added this pull request to the merge queue Sep 8, 2026
Merged via the queue into main with commit 413020b Sep 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants