feat(Isla): Partition page-table allocation arenas - #236
Open
febyeji wants to merge 1 commit into
Open
Conversation
Collaborator
|
Can you rebase this, please? |
febyeji
force-pushed
the
feature/pgt-allocation-arenas
branch
from
September 7, 2026 19:52
2231457 to
547f750
Compare
febyeji
force-pushed
the
feature/pgt-allocation-arenas
branch
from
September 8, 2026 10:24
547f750 to
7991fda
Compare
tperami
approved these changes
Sep 8, 2026
tperami
left a comment
tperami
left a comment
Collaborator
There was a problem hiding this comment.
Some code readability things, but the code is good. Probably should mention the hardcoded layout in commit message too
| in | ||
| List.map (fun name -> (name, alignment_for name)) virtual_names | ||
|
|
||
| let make_arena ?(reserved = []) base = |
Collaborator
There was a problem hiding this comment.
Suggested change
| let make_arena ?(reserved = []) base = | |
| let make_arena ?(reserved = []) base = | |
| assert (base land 0x1FFFFF == 0); |
|
|
||
| page_table_setup = """ | ||
| virtual x y; | ||
| aligned 2097152 virtual x; |
Use the fixed layout of 0-2 MiB for code, 2-4 MiB for translation tables, and addresses at or above 4 MiB for data.
febyeji
force-pushed
the
feature/pgt-allocation-arenas
branch
from
September 9, 2026 10:18
7991fda to
efe3e21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep code and translation-table allocations within dedicated 2 MiB arenas, and begin page-table data allocation after them.