feat(ci): add actionlint workflow validation job - #39
Merged
Conversation
| tar -xzf actionlint.tar.gz actionlint | ||
|
|
||
| - name: Lint GitHub Actions workflows | ||
| run: ./actionlint |
There was a problem hiding this comment.
Workflow linter receives no workflow paths
actionlint v1.7.12 does not discover files under .github/workflows when it is invoked without positional paths. As a result, ./actionlint exits successfully without checking any workflow, including when a workflow is invalid. Pass every workflow file explicitly, covering both .yml and .yaml extensions where applicable.
Artifacts
Executed actionlint no-argument reproduction script
- The repo-local script recreates the pinned download/checksum/extraction flow and compares no-argument behavior with explicit workflow paths; the takeaway is that it deterministically tests the CI command's silent-skip condition.
Executed actionlint no-argument reproduction output
- Captured output records checksum success and `noarg_with_invalid_workflow=0 explicit_invalid_workflow=1 noarg_pr_ci=0 explicit_pr_ci=0`; the takeaway is that `./actionlint` silently skips workflow validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a lint-workflows CI job that validates .github/workflows with actionlint v1.7.12.
Details:
Verified locally: actionlint v1.7.12 passes on the updated ci.yml (exit 0).
Greptile Summary
Adds a CI job that downloads a checksum-verified actionlint v1.7.12 binary and checks the repository’s GitHub Actions workflows.
The prior workflow-discovery concern was disproved: running actionlint v1.7.12 without positional paths from a repository root detected and rejected a deliberately invalid workflow under
.github/workflows.Confidence Score: 5/5
No blocking failure remains.
No accepted blocking findings remain. An executable check confirmed that the command in
.github/workflows/ci.ymldiscovers workflows under.github/workflowswhen run from the repository root.What T-Rex did
Reviews (3): Last reviewed commit: "feat(ci): add actionlint workflow valida..." | Re-trigger Greptile