fix(ci): restrict GITHUB_TOKEN to contents: read - #36
Merged
Conversation
The workflow declared no permissions block, so the job inherited the repository default. That default is a repo-level setting rather than a property of the workflow, and repos created from this template may carry read-write defaults. checkout needs contents: read; setup-node and the npm steps need no token scope, so nothing requires write.
iap
added a commit
that referenced
this pull request
Aug 26, 2026
The workflow declared no permissions block, so the job inherited the repository default. That default is a repo-level setting rather than a property of the workflow, and repos created from this template may carry read-write defaults. checkout needs contents: read; setup-node and the npm steps need no token scope, so nothing requires write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the one open code-scanning alert on
master:actions/missing-workflow-permissions(medium,.github/workflows/ci.yml:11-27).permissions:block, so the job inherited the repository default. CodeQL flags this because the default is a repo-level setting, not a property of the workflow — and repositories created before February 2023, or under organizations with read-write defaults, grant the job far more than it needs.permissions: contents: read.Scope check against the steps present:
actions/checkoutneedscontents: read;actions/setup-nodeand thenpm ci/npm teststeps need no token scope. Nothing in this workflow requires write.This matters more than usual here because the repository is a template — the workflow is copied into every repo generated from it, where the inherited default may differ.
Test plan
master