Skip to content

chore(ci): drop leftover X11 MIT-SHM env from e2e-runner - #5191

Open
zdrapela wants to merge 1 commit into
redhat-developer:mainfrom
zdrapela:chore/remove-dockerfile-x11-env
Open

chore(ci): drop leftover X11 MIT-SHM env from e2e-runner#5191
zdrapela wants to merge 1 commit into
redhat-developer:mainfrom
zdrapela:chore/remove-dockerfile-x11-env

Conversation

@zdrapela

@zdrapela zdrapela commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

These env vars only matter when an X server is in use. CI Playwright runs headless and no longer starts Xvfb.

Test plan

  • Confirm PR diff is only .ci/images/Dockerfile
  • e2e-runner image builds successfully on the PR
  • An e2e job still reaches Playwright without Missing X server / DISPLAY errors

Follow-up to RHIDP-15894 / redhat-developer#5188. Xvfb is no longer started for
headless Playwright, so these Dockerfile env vars are unused.
@openshift-ci
openshift-ci Bot requested review from kadel and teknaS47 July 29, 2026 13:08
@sonarqubecloud

Copy link
Copy Markdown

@zdrapela

Copy link
Copy Markdown
Member Author

/hold

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

ci: Remove unused X11 MIT-SHM env vars from e2e-runner image

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Remove obsolete X11 MIT-SHM environment variables from the e2e-runner Dockerfile.
• Align CI image config with headless Playwright runs (no Xvfb / no X server).
• Reduce CI image surface area and avoid misleading X11-related settings.
High-Level Assessment

The straightforward cleanup is appropriate: since CI Playwright runs headless and Xvfb is no longer started, keeping X11 MIT-SHM env vars only adds confusion. No alternative approach provides meaningful benefit beyond leaving dead config in place.

Files changed (1) +0 / -3

Other (1) +0 / -3
DockerfileDrop unused X11 MIT-SHM env vars from CI image +0/-3

Drop unused X11 MIT-SHM env vars from CI image

• Removes QT_X11_NO_MITSHM, _X11_NO_MITSHM, and _MITSHM from the e2e-runner container environment. These variables are only relevant when an X server is used, which is no longer the case for headless Playwright in CI.

.ci/images/Dockerfile

@rhdh-qodo-merge

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

To customize comments, go to the Qodo configuration screen, or learn more in the docs.

Qodo Logo

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.96%. Comparing base (ddfe8d0) to head (8a594a9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5191      +/-   ##
==========================================
- Coverage   63.69%   59.96%   -3.74%     
==========================================
  Files         123      111      -12     
  Lines        2424     2198     -226     
  Branches      548      546       -2     
==========================================
- Hits         1544     1318     -226     
  Misses        879      879              
  Partials        1        1              
Flag Coverage Δ
rhdh 59.96% <ø> (-3.74%) ⬇️
Components Coverage Δ
Backend plugins ∅ <ø> (∅)
Backend app 66.66% <ø> (ø)
Frontend app 58.89% <ø> (ø)
Plugin utils ∅ <ø> (∅)
Dynamic plugins utils ∅ <ø> (∅)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddfe8d0...8a594a9. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant