RDKEMW-21912: Enabling support for RFC by KonkatiBhavani · Pull Request #529 · rdkcentral/tr69hostif

KonkatiBhavani · 2026-08-16T12:05:05Z

No description provided.

github-actions · 2026-08-16T12:05:13Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-08-16T12:12:11Z

Code Coverage Summary

                                        Total:|73.7%  9645|90.2% 661|    -    0

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-08-17T06:45:21Z

Code Coverage Summary

                                        Total:|73.7%  9645|90.2% 661|    -    0

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-08-19T06:48:30Z

Code Coverage Summary

                                        Total:|73.5%  9696|90.2% 661|    -    0

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Suppressed comments (1)

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:4031

get_xRDKCentralComRFCLogChronoEnable() appears to return the inverted value: it sets isEnabled=true when the disable flag file exists. Since set_xRDKCentralComRFCLogChronoEnable(true) removes LOGCHRONO_DISABLE_FILE and set(false) creates it, the getter should report enabled when the file is absent (e.g., access(...) != 0).

    stMsgData->paramtype = hostIf_BooleanType;
    bool isEnabled = (access(LOGCHRONO_DISABLE_FILE, F_OK) == 0) ? true : false;
    put_boolean(stMsgData->paramValue, isEnabled);
    stMsgData->paramLen = sizeof(bool);
    stMsgData->faultCode = fcNoFault;

 #include <cmath>
 #include <cstring>
+#include <string>
+#include <fstream>
+#include <cstdio>
+#include <errno.h>
+#include <unistd.h>


github-actions · 2026-08-24T06:23:30Z

Code Coverage Summary

                                        Total:|73.5%  9664|90.2% 660|    -    0

rebase

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Suppressed comments (2)

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:47

The newly added standard headers are duplicated later in this file (e.g., <string>, <fstream>, and <errno.h> already appear again around lines 57–64). This increases include noise and can slow compilation; please remove the duplicates and keep only the minimal new headers required for this change.

#include <string>
#include <fstream>
#include <cstdio>
#include <errno.h>
#include <unistd.h>

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:3950

New RFC set/get behavior was added for Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.LogChrono.Enable, but there are no corresponding DeviceInfo gtests for it. There are already tests for similar RFC toggles (e.g., NewNtpEnable in profiles/DeviceInfo/gtest/gtest_main.cpp), so adding tests for LogChrono enable/disable and GET default behavior would help prevent regressions.

int hostIf_DeviceInfo::set_xRDKCentralComRFCLogChronoEnable(HOSTIF_MsgData_t *stMsgData)
{
    int ret = NOK;
    bool enable;
    LOG_ENTRY_EXIT;

github-actions · 2026-08-24T09:13:46Z

Code Coverage Summary

                                        Total:|73.5%  9664|90.2% 660|    -    0

KonkatiBhavani · 2026-08-24T09:14:56Z

I have read the CLA Document and I hereby sign the CLA

github-actions · 2026-08-26T13:06:28Z

Code Coverage Summary

                                        Total:|62.4%  2813|64.8% 247|    -    0

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:47

The newly added headers duplicate existing includes later in this file (e.g., , , <errno.h> are already included again below). This increases compile time/noise and can cause subtle ordering issues; it’s better to include each header only once.

#include <string>
#include <fstream>
#include <cstdio>
#include <errno.h>
#include <unistd.h>

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:3983

This PR introduces a new RFC setter (LogChrono.Enable) with filesystem side effects, but there’s no corresponding unit test coverage. There are existing gtests for similar flag-file RFC setters (e.g., NewNtpEnable in src/hostif/profiles/DeviceInfo/gtest/gtest_main.cpp) that could be mirrored to verify disable_logchrono creation/removal and return codes.

int hostIf_DeviceInfo::set_xRDKCentralComRFCLogChronoEnable(HOSTIF_MsgData_t *stMsgData)
{
    int ret = NOK;
    bool enable;
    LOG_ENTRY_EXIT;

    if(stMsgData->paramtype == hostIf_BooleanType)
    {
        enable = get_boolean(stMsgData->paramValue);
        if(enable)
        {
            RDK_LOG(RDK_LOG_INFO,LOG_TR69HOSTIF,"[%s] set LogChrono.Enable to true\n", __FUNCTION__);
            if(remove(LOGCHRONO_DISABLE_FILE) != 0 && errno != ENOENT)
            {
                RDK_LOG(RDK_LOG_ERROR,LOG_TR69HOSTIF,"[%s] Unable to clear disable logchrono flag %s\n",
                        __FUNCTION__, LOGCHRONO_DISABLE_FILE);
                ret = NOK;
            }
            else
            {
                ret = OK;
            }
        }
        else
        {
            RDK_LOG(RDK_LOG_INFO,LOG_TR69HOSTIF,"[%s] set LogChrono.Enable to false\n", __FUNCTION__);
            std::ofstream disableFile(LOGCHRONO_DISABLE_FILE);
            if(!disableFile.is_open())
            {
                RDK_LOG(RDK_LOG_ERROR,LOG_TR69HOSTIF,"[%s] Unable to create disable logchrono flag %s\n",
                        __FUNCTION__, LOGCHRONO_DISABLE_FILE);
                ret = NOK;
            }
            else
            {
                disableFile.close();
                ret = OK;
            }

github-actions · 2026-09-09T12:27:35Z

Code Coverage Summary

                                        Total:|62.4%  2813|64.8% 247|    -    0

Copilot

🟡 Changes recommended

The new LogChrono toggle implementation introduces security/operability issues (flag-file creation permissions and missing errno details) and some maintainability regressions that should be corrected before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (2)

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:47

These headers are already included later in this file (e.g., , , <errno.h>), so adding them again here introduces redundant/duplicate includes and makes the include list harder to maintain.

#include <string>
#include <fstream>
#include <cstdio>
#include <errno.h>
#include <unistd.h>

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:3983

On failure to remove the disable flag, the log drops the underlying error, which makes field debugging difficult. Please include strerror(errno) (as done elsewhere in this file, e.g. DistributedTracing handling).

            if(remove(LOGCHRONO_DISABLE_FILE) != 0 && errno != ENOENT)
            {
                RDK_LOG(RDK_LOG_ERROR,LOG_TR69HOSTIF,"[%s] Unable to clear disable logchrono flag %s\n",
                        __FUNCTION__, LOGCHRONO_DISABLE_FILE);
                ret = NOK;

Files reviewed: 3/3 changed files
Comments generated: 2
Review effort level: Lite

+            RDK_LOG(RDK_LOG_INFO,LOG_TR69HOSTIF,"[%s] set LogChrono.Enable to false\n", __FUNCTION__);
+            std::ofstream disableFile(LOGCHRONO_DISABLE_FILE);
+            if(!disableFile.is_open())
+            {
+                RDK_LOG(RDK_LOG_ERROR,LOG_TR69HOSTIF,"[%s] Unable to create disable logchrono flag %s\n",
+                        __FUNCTION__, LOGCHRONO_DISABLE_FILE);
+                ret = NOK;
+            }
+            else
+            {
+                disableFile.close();
+                ret = OK;
+            }


+        <syntax>
+         <boolean/>
+           <default type="factory" value="true"/>
+        </syntax>


RDKEMW-19847: Migrate RDKE Logupload Triggers from System Calls to AP…

Copilot

🟡 Changes recommended

Unresolved moderate findings affect error handling, validation, and test coverage.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (3)

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:3971

Please add tests for this new side-effecting RFC path. The existing DeviceInfo suite covers RFC setters and invalid-type branches, but neither the true/false transitions nor file-operation failures for disable_logchrono are exercised, so regressions in the flag state or return status can pass CI.

int hostIf_DeviceInfo::set_xRDKCentralComRFCLogChronoEnable(HOSTIF_MsgData_t *stMsgData)
{
    int ret = NOK;
    bool enable;
    LOG_ENTRY_EXIT;

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:4003

is_open() only verifies that the stream was opened; a write/close error can still leave the disable flag unavailable. Because ret is set to OK unconditionally after close(), the SET can report success even though the flag was not successfully committed. Check the stream state after closing before returning success.

                disableFile.close();
                ret = OK;

src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:3976

This type check runs after set_xRDKCentralComRFC has already persisted stMsgData->paramValue to the RFC store, so a non-boolean SET can write an invalid value even though this handler returns NOK; the error branch at lines 4007-4010 also leaves faultCode unchanged. Validate this parameter as boolean before the generic store write and report fcInvalidParameterType on rejection.

    if(stMsgData->paramtype == hostIf_BooleanType)
    {
        enable = get_boolean(stMsgData->paramValue);
        if(enable)

Files reviewed: 3/3 changed files
Comments generated: 1
Review effort level: Lite

+    else if (!strcasecmp(stMsgData->paramName, LOGCHRONO_RFC_ENABLE))
+    {
+        ret = set_xRDKCentralComRFCLogChronoEnable(stMsgData);


github-actions · 2026-09-10T08:27:19Z

Code Coverage Summary

                                        Total:|73.6%  9668|90.3% 660|    -    0

Konkati_Bhavani and others added 3 commits August 16, 2026 12:02

Chnages for RFC LogChrono

6808f85

Chnages for XML File

a5d3cbd

Changes for LogChrono in set handler

0ef191b

Copilot AI lite review requested due to automatic review settings August 16, 2026 12:05

KonkatiBhavani requested a review from a team as a code owner August 16, 2026 12:05

Copilot AI reviewed Aug 16, 2026

Chane in directory for RFC

f1cc5a1

Copilot AI review requested due to automatic review settings August 17, 2026 06:38

Copilot AI reviewed Aug 17, 2026

Change_for_directory_name

4d75fb7

Copilot AI review requested due to automatic review settings August 19, 2026 06:42

Copilot AI reviewed Aug 19, 2026

Changes for RFC with review comments

adec085

Copilot AI review requested due to automatic review settings August 24, 2026 06:17

Copilot started reviewing on behalf of KonkatiBhavani August 24, 2026 06:18 View session

Copilot AI reviewed Aug 24, 2026

View reviewed changes

rebase

5a98499

rebase

Copilot AI review requested due to automatic review settings August 24, 2026 09:07

Copilot started reviewing on behalf of KonkatiBhavani August 24, 2026 09:08 View session

Copilot AI reviewed Aug 24, 2026

View reviewed changes

Comment thread src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp Outdated

Comment thread src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp

Change for removing the get RFC for Boot_id

78d01e0

Copilot AI review requested due to automatic review settings August 26, 2026 13:02

Copilot started reviewing on behalf of KonkatiBhavani August 26, 2026 13:03 View session

Copilot AI reviewed Aug 26, 2026

View reviewed changes

KonkatiBhavani changed the title ~~Feature/rdkemw 23244~~ RDKEMW-21912: Enabling support for RFC Aug 27, 2026

Merge branch 'develop' into feature/RDKEMW-23244

7d30fb3

Copilot AI review requested due to automatic review settings September 9, 2026 12:23

Copilot started reviewing on behalf of KonkatiBhavani September 9, 2026 12:24 View session

Copilot AI reviewed Sep 9, 2026

View reviewed changes

Merge pull request #551 from rdkcentral/develop

b24b320

RDKEMW-19847: Migrate RDKE Logupload Triggers from System Calls to AP…

Copilot AI review requested due to automatic review settings September 10, 2026 08:21

Copilot started reviewing on behalf of KonkatiBhavani September 10, 2026 08:21 View session

Copilot AI reviewed Sep 10, 2026

View reviewed changes

Comment thread src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp

Comment on lines +3843 to +3845

else if (!strcasecmp(stMsgData->paramName, LOGCHRONO_RFC_ENABLE))

{

ret = set_xRDKCentralComRFCLogChronoEnable(stMsgData);

Uh oh!

Conversation

KonkatiBhavani commented Aug 16, 2026

Uh oh!

github-actions Bot commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 16, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 17, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 19, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions Bot commented Aug 24, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 24, 2026

Code Coverage Summary

Uh oh!

KonkatiBhavani commented Aug 24, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Sep 9, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (2)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (3)

Uh oh!

github-actions Bot commented Sep 10, 2026

Code Coverage Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Aug 16, 2026 •

edited

Loading