RDKEMW-24896: Adding Debug Logs - #294
Open
yuvaramachandran-gurusamy wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yuvaramachandran Gurusamy <yuvaramachandran_gurusamy@comcast.com>
Copilot started reviewing on behalf of
yuvaramachandran-gurusamy
September 11, 2026 14:17
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a minor log line-termination nit remains; no blocking issues were identified.
Pull request overview
Adds diagnostic logging around the dsGetEDIDBytes HAL call.
Changes:
- Logs the display handle before invocation.
- Logs the return code and EDID length afterward.
File summaries
| File | Summary |
|---|---|
rpc/srv/dsDisplay.c |
Adds EDID retrieval diagnostics. |
Review details
Suppressed comments (1)
rpc/srv/dsDisplay.c:270
- These new messages do not include a line terminator. Since
INT_INFOfalls back toprintfwhen the RDK logger is disabled (and the neighboring messages in this function use\r\n), the two records can be concatenated with the HAL output and subsequent logs. Terminate both messages consistently.
INT_INFO("Calling dsGetEDIDBytes for handle %ld", (long)param->handle);
dsError_t ret = func(param->handle, edid, &length);
INT_INFO("dsGetEDIDBytes returned %d with length %d", ret, length);
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.