Skip to content

RDKEMW-24896: Adding Debug Logs - #294

Open
yuvaramachandran-gurusamy wants to merge 1 commit into
support/8.6.3.0from
topic/RDKEMW-24896
Open

RDKEMW-24896: Adding Debug Logs#294
yuvaramachandran-gurusamy wants to merge 1 commit into
support/8.6.3.0from
topic/RDKEMW-24896

Conversation

@yuvaramachandran-gurusamy

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Yuvaramachandran Gurusamy <yuvaramachandran_gurusamy@comcast.com>
Copilot AI lite review requested due to automatic review settings September 11, 2026 14:17
@yuvaramachandran-gurusamy
yuvaramachandran-gurusamy requested a review from a team as a code owner September 11, 2026 14:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only a minor log line-termination nit remains; no blocking issues were identified.

Pull request overview

Adds diagnostic logging around the dsGetEDIDBytes HAL call.

Changes:

  • Logs the display handle before invocation.
  • Logs the return code and EDID length afterward.
File summaries
File Summary
rpc/srv/dsDisplay.c Adds EDID retrieval diagnostics.
Review details

Suppressed comments (1)

rpc/srv/dsDisplay.c:270

  • These new messages do not include a line terminator. Since INT_INFO falls back to printf when the RDK logger is disabled (and the neighboring messages in this function use \r\n), the two records can be concatenated with the HAL output and subsequent logs. Terminate both messages consistently.
        INT_INFO("Calling dsGetEDIDBytes for handle %ld", (long)param->handle);
        dsError_t ret = func(param->handle, edid, &length);
        INT_INFO("dsGetEDIDBytes returned %d with length %d", ret, length);
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants