Handle compacting an empty delta - #607
Merged
Merged
Conversation
yankevn
marked this pull request as ready for review
April 17, 2026 00:26
Zyiqin-Miranda
left a comment
Member
There was a problem hiding this comment.
On a high-level, any particular reason (I assume just for minimal changes) to commit an empty delta with empty manifests?
Collaborator
Author
|
Yeah, committing an empty delta means that at least there's something committed vs an empty staged partition. When I initially tested by just skipping the committed delta, the follow-up job failed, which is why I added the empty delta. |
Zyiqin-Miranda
approved these changes
Apr 17, 2026
Zyiqin-Miranda
left a comment
Member
There was a problem hiding this comment.
Looks good, maybe good idea to add empty->incremental, incremental->empty->incremental test cases to guard the behavior, especially around stream_position/rcf fetching/deriving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change handles the case where the delta results in no materialize results. In this case, committing the delta will be skipped in favor of directly writing back the RCF.
Rationale
Empty deltas may occur, which will result in an assertion error during the merge deltas step while processing the merge results.
Changes
List the major changes made in this pull request.
Impact
Discuss any potential impacts the changes may have on existing functionalities.
Testing
Describe how the changes have been tested, including both automated and manual testing strategies.
If this is a bugfix, explain how the fix has been tested to ensure the bug is resolved without introducing new issues.
Regression Risk
If this is a bugfix, assess the risk of regression caused by this fix and steps taken to mitigate it.
Checklist
Unit tests covering the changes have been added
E2E testing has been performed
Additional Notes
Any additional information or context relevant to this PR.