Set cuda_suffixed=false;use_cuda_wheels=false in devcontainers dependency generation - #757
Closed
bdice wants to merge 1 commit into
Closed
Set cuda_suffixed=false;use_cuda_wheels=false in devcontainers dependency generation#757bdice wants to merge 1 commit into
bdice wants to merge 1 commit into
Conversation
Collaborator
|
@KyleFromNVIDIA did this in #751 and #753 |
Contributor
Author
Contributor
Author
|
I think I launched my container wrong somehow. I got version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are adopting a new convention where dependency lists explicitly require
cuda_suffixedanduse_cuda_wheelsto be set. Currently cudf devcontainers fail on thedepends_on_kvikiolist when only the CUDA version is set and the suffix/wheels settings are left unset. This sets those values explicitly to helprapids-dependency-file-generatordo the right thing.