Skip to content

improvements to the LULC workflow example - #742

Merged
ncclementi merged 4 commits into
rapidsai:mainfrom
jayavenkatesh19:lulc-example-enhancements
Aug 14, 2026
Merged

improvements to the LULC workflow example#742
ncclementi merged 4 commits into
rapidsai:mainfrom
jayavenkatesh19:lulc-example-enhancements

Conversation

@jayavenkatesh19

Copy link
Copy Markdown
Contributor

Closes #641

@jayavenkatesh19 jayavenkatesh19 self-assigned this Aug 13, 2026
@jayavenkatesh19
jayavenkatesh19 requested a review from a team as a code owner August 13, 2026 20:44
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app

review-notebook-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

ncclementi commented on 2026-08-13T21:58:21Z
----------------------------------------------------------------

Should we link into other docs on how to setup the cluster?


@review-notebook-app

review-notebook-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

ncclementi commented on 2026-08-13T21:58:21Z
----------------------------------------------------------------

Not sure I follow what do you mean by "stock" RAPIDS installation, in the first sentence. The whole paragraph makes emphasis on how a rapids installation is not enough, but we are not installing ll rapids, so let's change the narrative around what we are using and how it integrates with cudf, cuml, etc.

Also where is this being installed? Was this a local cluster? If someone needs to use run this let's say in aws or similar how they get the cluster going? We should link to some docs to help in this step, and clarify we run this locally if that's what we did.

I think this feels a bit disconnected. Like how would the user get to this point?


@review-notebook-app

review-notebook-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

ncclementi commented on 2026-08-13T21:58:22Z
----------------------------------------------------------------

Do we have a guide to point to people on how to create this file? I noticed we do provide a geojson file, We should mentioned this as an example.


@review-notebook-app

review-notebook-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

View / edit / reply to this conversation on ReviewNB

ncclementi commented on 2026-08-13T21:58:23Z
----------------------------------------------------------------

nitpick: the color labels are very hard to read is it possible to have the box somewhere else to make sure we can read it?


dependencies:
- python=3.13
- cuda-version>=13.0,<=13.2
- rapids=26.08

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to install all rapids? since we are already installing bunch of other stuff. Do we need all rapids?

@ncclementi ncclementi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayavenkatesh19 and I did a final path review together, this is good to go.

@ncclementi
ncclementi merged commit 12938da into rapidsai:main Aug 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancements for the LULC classification workflows example

2 participants