Fix the potential ADL issue in cugraph::detail::gather/scatter - #5634
Merged
Conversation
Contributor
Author
|
/ok to test f02d761 |
Contributor
Author
|
/ok to test da54138 |
jnke2016
approved these changes
Aug 19, 2026
ChuckHastings
approved these changes
Aug 19, 2026
Collaborator
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
thrust::scatter(orthrust::gather) can recurse until the host stack overflows when argument types pull incugraph::detail(e.g. transform iterators with thecugraph::detail::shift_left_tfunctor).Thrust dispatches via an unqualified scatter/gather call (ADL). That found
cugraph::detail::scatter/gather, whose fallback calledthrust::scatter/gatheragain → infinite recursion. The publiccugraph::scatter/gatherfunctors already avoided this; the detailscatter (gather)functions reintroduced it.Rename the detail
scatter (gather)functions toscatter_dispatch(gather_dispatch) (andscater|gather_shift_left_dispatchfor consistency) so they are no longer ADL targets for Thrust.