[BUG] Fix Segfault Caused by Incorrect Dereferencing of Renumber Map - #5632
Merged
rapids-bot[bot] merged 2 commits intoAug 19, 2026
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ChuckHastings
approved these changes
Aug 19, 2026
Collaborator
|
/ok to test 3cae514 |
ChuckHastings
marked this pull request as ready for review
August 19, 2026 19:57
ChuckHastings
approved these changes
Aug 19, 2026
Collaborator
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the sampling-result C API accessors
renumbered homogeneous sampling result
Problem
cugraph_sample_result_get_edge_renumber_map()andcugraph_sample_result_get_edge_renumber_map_offsets()currently check whetherthe vertex
renumber_map_is null, then dereference the corresponding optionaledge renumber map pointer.
A sampling result can validly contain a vertex renumber map without an edge
renumber map. In particular, heterogeneous sampling with one edge type returns
that layout. Calling either accessor then dereferences a null pointer and
segfaults while pylibcugraph marshals an otherwise completed sampling result.
Fix
Each accessor now checks the pointer it actually dereferences:
edge_renumber_map_edge_renumber_map_offsets_The accessors return null for absent optional results, matching the behavior of
the other sampling-result accessors and the existing pylibcugraph null handling.
Validation
end-to-end against an exact-baseline libcugraph build containing only this
accessor fix
that the empty-frontier fix is independent