split out kmod module as an internal crate - #278
Merged
Conversation
thackara
reviewed
Aug 6, 2026
thackara
approved these changes
Aug 6, 2026
thackara
left a comment
Contributor
There was a problem hiding this comment.
Please let me know if you are you okay with the
kmod-parsercrate name.
The name looks good to me David. The PR changes look good to me as well.
The kmod code is quite modular, and this appears to make it a little easier to consume when splitting out bits of rapido-cut as a library. Use kmod-parser as a name, to avoid conflict with the proper libkmod bindings. Signed-off-by: David Disseldorp <ddiss@suse.de> Reviewed-by: Sangeetha Thackarajan <sangeetha.thackarajan@suse.com>
With the kmod module now spit out as a kmod-parser crate, ci needs to explicitly run unit tests from the crate directory. Use the test --manifest-path parameter instead of directory-jumping. Suggested-by: Sangeetha Thackarajan <sangeetha.thackarajan@suse.com> Signed-off-by: David Disseldorp <ddiss@suse.de> Reviewed-by: Sangeetha Thackarajan <sangeetha.thackarajan@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thackara : Please let me know if you are you okay with the
kmod-parsercrate name. I'd be happy to use any other name if you have a preference.