fix(wyvern): fix broken art + add reactions for wyvern and pikachu - #126
Open
TorranceTech wants to merge 4 commits into
Open
fix(wyvern): fix broken art + add reactions for wyvern and pikachu#126TorranceTech wants to merge 4 commits into
TorranceTech wants to merge 4 commits into
Conversation
Wyvern art had 6 lines per frame (spec requires exactly 5) and
frame 1 contained forbidden ANSI escape sequences. Redesigned all
three frames to comply with the art format spec: 5 lines, ≤14 display
chars per line, no ANSI codes, {E} eye placeholder on line 2.
Wing beat animation now cycles: spread (^) → mid-beat (v) → shimmer (~).
Signed-off-by: TorranceTech <billy.anderson.it@gmail.com>
Wyvern and pikachu were listed in SPECIES and had art but zero species-specific reactions — they fell back entirely to the generic pool. Added ~14 reaction pools per species covering: error, test-fail, commit, push, merge-conflict, late-night, type-error, lint-fail, build-fail, all-green, deploy, pet, idle, hatch, large-diff. Wyvern: ancient/serpentine voice — cryptic, regal, fire-breath themed. Pikachu: electric/energetic voice — sparky, enthusiastic, cheek-glow themed. Signed-off-by: TorranceTech <billy.anderson.it@gmail.com>
Previous fix left lines 3-4 at 11 chars while lines 0-2 were 9 chars, making the body appear wider than the head in the status line. All five lines are now consistently 9 display chars wide. Signed-off-by: TorranceTech <billy.anderson.it@gmail.com>
Lines 3-4 now use 1 leading space (8 chars) instead of 2 (9 chars), giving the body a natural taper below the wingspan. Frame 2 tail gets a ~swish and double-wave belly for animation variety. Signed-off-by: TorranceTech <billy.anderson.it@gmail.com>
Owner
|
Hey @TorranceTech — heads up: #114 just merged and it included a wyvern art fix in 🤖 Created with the help of AI (Claude Fable 5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/art.ts): the wyvern had 6 lines per frame (spec requires 5) and frame 1 contained forbidden ANSI escape sequences. Redesigned all three frames to comply with the format spec.server/reactions.ts): ~14 species-specific reaction pools with an ancient/serpentine voice — regal, cryptic, fire-breath themed. Distinct from the dragon.server/reactions.ts): ~14 species-specific reaction pools with an electric/energetic voice — sparky, cheek-glow themed, high energy.Both species were listed in
SPECIESand had art, but zero species-specific reactions — they fell back entirely to the generic pool.Wyvern art preview (3 frames)
Test plan
bun test— all 246 tests pass{E}placeholder on line 2getReactiontest covers every(reason, species, rarity)combo including wyvern and pikachu🤖 Generated with Claude Code