fix: restore executable bit on suggest.sh Stop hook - #122
Open
skpalan wants to merge 1 commit into
Open
Conversation
suggest.sh shipped with mode 100644 (no execute bit) in 53bf15a. Claude Code invokes Stop hooks as direct commands, so the missing +x makes the hook fail with "permission denied" (exit 126) and surfaces a "Stop hook error occurred" banner after every turn. Restore mode 100755 to match the other hook scripts (react.sh, buddy-comment.sh, name-react.sh, etc.).
Owner
|
Hey @skpalan — thanks for this fix! The only thing blocking it from getting CI + review is the DCO check: the commit(s) are missing a Quick fix from your branch: git commit --amend -s --no-edit # single commit
# or, for multiple commits:
git rebase --signoff origin/main
git push --force-with-leaseOnce DCO goes green we can run CI and get this reviewed — it's a small, wanted change. 🤖 Created with the help of AI (Claude Fable 5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hooks/suggest.shwas committed without the execute bit (mode100644) in 53bf15a (the v0.5.x suggestions feature). Claude Code invokes Stop hooks as direct commands, so the missing+xcauses the hook to fail immediately:This surfaces a "Stop hook error occurred" banner after every turn for anyone who installs/upgrades to v0.5.x. Every other hook script (
react.sh,buddy-comment.sh,name-react.sh,mood-react.sh,file-type-react.sh) ships as100755;suggest.shis the lone exception.Repro
Fix
Restore mode
100755to match the sibling hook scripts. No content change.Suggestion (follow-up)
To prevent regressions if the bit is lost again,
cli/install.tscouldchmod +xthe hook scripts during installation.