fix: allow empty array for rainbow reset in buddy_style - #119
Open
yehuosi wants to merge 1 commit into
Open
Conversation
The Zod schema had .min(1) which rejected [] at validation time, preventing /buddy rainbow reset from working. The handler already correctly treats empty array as a reset signal (line 494). Lowering the minimum to 0 lets the reset path reach the handler. Also updates the tool description to document [] as the reset value.
Owner
|
Hey @yehuosi — thanks for this fix! The only thing blocking it from getting CI + review is the DCO check: the commit(s) are missing a Quick fix from your branch: git commit --amend -s --no-edit # single commit
# or, for multiple commits:
git rebase --signoff origin/main
git push --force-with-leaseOnce DCO goes green we can run CI and get this reviewed — it's a small, wanted change. 🤖 Created with the help of AI (Claude Fable 5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/buddy rainbow resetcommand passes[]tobuddy_style, but the Zod schema had.min(1)which rejected empty arrays at validation time — the handler never ran. The fix is.min(0). The handler at line 494 already correctly treats[]as a reset signal.