fix(pbt): follow Bombadil 0.7's click schema - #1464
Merged
Merged
Conversation
The nightly property run has failed every night since 2026-08-14, when Dependabot took Bombadil from 0.6.1 to 0.7.0 (#1409). Two schema changes, one visible only after the first: `Click` now carries a `fingerprint` of the element rather than a `name`, so a replay can tell whether the thing it is about to click is still the thing the original run clicked. Built with the library's own `getFingerprint` rather than by hand, so it keeps matching whatever the schema asks for next. With that fixed the run got as far as its first scroll and then failed on `value must not be negative`: bounding rects are relative to the viewport, so anything scrolled past reports negative coordinates, which 0.7 rejects. Only what is on screen is offered now. Scrolling is its own action, and what it reveals becomes clickable in the next state. Verified locally: a 60-second exploration completes and reports no violations, having clicked buttons, inputs and spans throughout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XDxiHpQJkRKWctS9BfQmbY Entire-Checkpoint: ecb4082e1016
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1464 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 62 62
Lines 7680 7680
Branches 520 520
=======================================
Hits 7609 7609
Misses 71 71
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The nightly property run has failed every night since 2026-08-14, when
Dependabot took Bombadil from 0.6.1 to 0.7.0 (#1409). Not a 5.0.0 regression —
it predates the release by a week, and the last green run was 2026-08-13.
Two schema changes, the second visible only once the first was fixed:
Clickcarries afingerprint, not aname. 0.7'sActiontype is{ Click: { fingerprint: Fingerprint; point: Point } }, so a replay cantell whether the element it is about to click is still the one the original
run clicked. Built with the library's exported
getFingerprintrather thanassembling the struct by hand, so it keeps matching whatever the schema asks
for next. Failure was
failed to convert generated action from clickButtons: missing field 'fingerprint'.Negative coordinates are rejected. With the first fixed, the run got as
far as its first scroll and died on
value must not be negative. Boundingrects are relative to the viewport, so anything scrolled past reports
negative coordinates. Only on-screen elements are offered now — scrolling is
its own action, and what it reveals becomes clickable in the next state.
Type of change
Additional information
Verified locally rather than by waiting for the nightly: a 60-second headless
exploration completes and reports no violations, having clicked buttons, inputs
and spans throughout. Before the fix it died in under a second.
Worth noting the failure mode — a scheduled job that only runs at 08:17 UTC and
notifies nobody was broken for eight days without anyone noticing. Might be
worth having it open an issue on failure.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XDxiHpQJkRKWctS9BfQmbY