Skip to content

fix(pbt): follow Bombadil 0.7's click schema - #1464

Merged
raman325 merged 1 commit into
mainfrom
fix/bombadil-0-7-click-fingerprint
Aug 21, 2026
Merged

fix(pbt): follow Bombadil 0.7's click schema#1464
raman325 merged 1 commit into
mainfrom
fix/bombadil-0-7-click-fingerprint

Conversation

@raman325

Copy link
Copy Markdown
Owner

Proposed change

The nightly property run has failed every night since 2026-08-14, when
Dependabot took Bombadil from 0.6.1 to 0.7.0 (#1409). Not a 5.0.0 regression —
it predates the release by a week, and the last green run was 2026-08-13.

Two schema changes, the second visible only once the first was fixed:

  1. Click carries a fingerprint, not a name. 0.7's Action type is
    { Click: { fingerprint: Fingerprint; point: Point } }, so a replay can
    tell whether the element it is about to click is still the one the original
    run clicked. Built with the library's exported getFingerprint rather than
    assembling the struct by hand, so it keeps matching whatever the schema asks
    for next. Failure was failed to convert generated action from clickButtons: missing field 'fingerprint'.

  2. Negative coordinates are rejected. With the first fixed, the run got as
    far as its first scroll and died on value must not be negative. Bounding
    rects are relative to the viewport, so anything scrolled past reports
    negative coordinates. Only on-screen elements are offered now — scrolling is
    its own action, and what it reveals becomes clickable in the next state.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Verified locally rather than by waiting for the nightly: a 60-second headless
exploration completes and reports no violations, having clicked buttons, inputs
and spans throughout. Before the fix it died in under a second.

Worth noting the failure mode — a scheduled job that only runs at 08:17 UTC and
notifies nobody was broken for eight days without anyone noticing. Might be
worth having it open an issue on failure.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XDxiHpQJkRKWctS9BfQmbY

The nightly property run has failed every night since 2026-08-14, when
Dependabot took Bombadil from 0.6.1 to 0.7.0 (#1409). Two schema
changes, one visible only after the first:

`Click` now carries a `fingerprint` of the element rather than a `name`,
so a replay can tell whether the thing it is about to click is still the
thing the original run clicked. Built with the library's own
`getFingerprint` rather than by hand, so it keeps matching whatever the
schema asks for next.

With that fixed the run got as far as its first scroll and then failed
on `value must not be negative`: bounding rects are relative to the
viewport, so anything scrolled past reports negative coordinates, which
0.7 rejects. Only what is on screen is offered now. Scrolling is its own
action, and what it reveals becomes clickable in the next state.

Verified locally: a 60-second exploration completes and reports no
violations, having clicked buttons, inputs and spans throughout.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XDxiHpQJkRKWctS9BfQmbY
Entire-Checkpoint: ecb4082e1016
Copilot AI lite review requested due to automatic review settings August 21, 2026 12:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added javascript Pull requests that update javascript code bug Something isn't working labels Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.07%. Comparing base (7cadf02) to head (70a571b).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          62       62           
  Lines        7680     7680           
  Branches      520      520           
=======================================
  Hits         7609     7609           
  Misses         71       71           
Flag Coverage Δ
typescript 95.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raman325
raman325 merged commit 0420a65 into main Aug 21, 2026
16 checks passed
@raman325
raman325 deleted the fix/bombadil-0-7-click-fingerprint branch August 21, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants