chore(audit): remove reconciled legacy audit-run MD trees (2 runs)#250
Merged
Conversation
Delete the internal audit-run working directories 2026-03-10-01 (full run) and 2026-03-23-01. Every actionable finding is accounted for: the sole MEDIUM (A08-7 toDecimalString revert class) is FIXED and corroborated by closed issues #181/#182/#184/#185; all LOW findings are FIXED / WONTFIX / DOCUMENTED; the five items left PENDING in the 03-10 run are all resolved in 03-23. No CRITICAL/HIGH findings, and no unfiled actionable finding — nothing is lost. Note: these runs also contain a false-clear of the #239 class (pass5 marks mul() "CORRECT (overflow reverts)" for the exact checked add that in fact still Panics(0x11) on negative-exponent squaring). #239 is tracked independently (issue #239 + PR #244), so removing the working copies loses nothing — and drops a misleading "verified correct" note. The external Protofire audit PDF is retained. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (30)
💤 Files with no reviewable changes (30)
WalkthroughThe change removes or leaves absent audit-pass and triage Markdown reports under Changes
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Reviewed d3b1d61: ready — deletes only audit/*.md (2 legacy audit-run dirs, 30 files; PDF retained), zero non-audit files touched. The three red checks (rainix-sol/static, rs-static, rainix-sol/test) are all PRE-EXISTING main conditions — the no-vm.skip static gate + the deploy-pin/test red — which a markdown deletion cannot affect (main independently reds on rainix-sol/test). Admin-merging per approval. |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Contributor
|
Tip For best results, initiate chat on the files or code changes. SIZE=S |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Delete the internal audit-run working directories
2026-03-10-01(full run) and2026-03-23-01(30 MD files). The external Protofire audit PDF is retained.Why — nothing is lost
Checked both triages against the issue tracker and live source:
toDecimalStringpanics on large +exponent) is FIXED and corroborated by closed issues toDecimalString reverts on Floats produced by add/sub (UnformatableExponent) #181/Bug: toDecimalString(false) reverts on Floats produced by normal add/sub arithmetic #182/Non-scientific format emits strings parser cannot accumulate (positive-exp round-trip) #184/Scientific format near int32.max exponent produces un-parseable display exponent #185.Notable caveat (reinforces deletion)
These runs contain a false-clear of the #239 class: pass5 marks
mul()"CORRECT (overflow reverts)" for the exact checked add that in fact still Panics(0x11) on negative-exponent squaring (confirmed live on main by an adversarial-mutation pass). #239 is tracked independently (issue #239 + PR #244), so removing these working copies loses nothing — and drops a misleading "verified correct" note rather than preserving it.🤖 Generated with Claude Code
Summary by CodeRabbit