Re-enable jekyll-redirect-from to fix trailing slash 404s - #725
Open
koic wants to merge 1 commit into
Open
Conversation
The jekyll-redirect-from plugin was re-enabled in rails#563 so that URLs with a trailing slash (e.g. /doctrine/ and /doctrine/ja/) redirect to their canonical counterparts via `redirect_from` front matter. However, rails#630 accidentally commented it out again as an unrelated hunk, which made these trailing slash URLs return 404. Re-enabling the plugin restores the redirect stubs. The redirect loop previously fixed in rails#585 does not recur: all files with redirect_from were audited and none has a `redirect_from` path that collides with its own permalink output.
koic
force-pushed
the
re_enable_jekyll_redirect_from
branch
from
August 19, 2026 16:22
4a4e3a7 to
3162d95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jekyll-redirect-from plugin was re-enabled in #563 so that URLs with a trailing slash (e.g. /doctrine/ and /doctrine/ja/) redirect to their canonical counterparts via
redirect_fromfront matter. However, #630 accidentally commented it out again as an unrelated hunk, which made these trailing slash URLs return 404.Re-enabling the plugin restores the redirect stubs. The redirect loop previously fixed in #585 does not recur: all files with redirect_from were audited and none has a
redirect_frompath that collides with its own permalink output.