fix: prevent negative/zero amounts and add Reset Form button (#90) - #91
Open
amanvatss wants to merge 1 commit into
Open
fix: prevent negative/zero amounts and add Reset Form button (#90)#91amanvatss wants to merge 1 commit into
amanvatss wants to merge 1 commit into
Conversation
…que#90) - Update yup validation schemas in Expense.jsx, EditExpense.jsx, Income.jsx, and EditIncome.jsx to use number().positive() for the amount field, preventing zero or negative values from being submitted - Add a secondary "Reset" button next to the submit button in the Add Expense and Add Income forms, bound to react-hook-form's reset() Closes rahulhaque#90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #90
Bug Fix: Amount Validation
0or a negative valueExpense.jsxandIncome.jsxusedyup.string()whileEditExpense.jsxandEditIncome.jsxusedyup.number()for the sameamountfieldNew Feature: Reset Form Button
reset()methodFiles Changed
src/app/expense/Expense.jsxsrc/app/expense/EditExpense.jsxsrc/app/income/Income.jsxsrc/app/income/EditIncome.jsx