fix(glob): wrap RegExp compilation in try/catch and recurse compileFragment for brace alternatives - #66
Open
fuleinist wants to merge 1 commit into
Open
Conversation
…agment for brace alternatives
The glob pattern compiler had two safety gaps:
1. Brace alternatives used escapeRegex(), which escapes * and ? but
those are valid glob wildcards inside braces. This caused patterns
like **/{*.ts,*.tsx} to crash with SyntaxError ("Nothing to repeat")
instead of compiling correctly. Fix: use compileFragment() recursively
for each alternative so * and ? get proper glob handling.
2. The new RegExp() call in compileGlobPattern() was not guarded, so
any invalid regex source (e.g. from reversed character-class ranges
like [z-a]) would leak a raw SyntaxError to the caller instead of
the expected GlobPatternError. Fix: wrap in try/catch and rethrow
as GlobPatternError.
Fixes ragilhadi#52
Author
|
Small housekeeping note: I closed #67 as a duplicate of this PR — both fixed the same two issues in Re-verified the branch against current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The glob pattern compiler had two safety gaps:
Brace alternatives used escapeRegex(), which escapes
*and?but those are valid glob wildcards inside braces. This caused patterns like**/{*.ts,*.tsx}to crash with SyntaxError ("Nothing to repeat") instead of compiling correctly. Fix: use compileFragment() recursively for each alternative so*and?get proper glob handling.The new RegExp() call in compileGlobPattern() was not guarded, so any invalid regex source (e.g. from reversed character-class ranges like
[z-a]) would leak a raw SyntaxError to the caller instead of the expected GlobPatternError. Fix: wrap in try/catch and rethrow as GlobPatternError.Test Plan
**/{*.ts,*.tsx}compiles and matches correctly{src/a*.ts,src/b.ts}compiles and matches correctly[z-a].tsthrows GlobPatternError (not SyntaxError){*.tsthrows GlobPatternError (not SyntaxError)Fixes #52