Skip to content

Harden release validation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radwanparvez merged 1 commit into from
Jul 25, 2026
Merged

Harden release validation #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,19 @@ jobs:
print "SIGN_IDENTITY=$identity" >> "$GITHUB_ENV"

- name: Build and verify signed application
env:
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
run: |
./build.sh
codesign --verify --deep --strict --verbose=2 \
build/JLabTextQuickLook.app
signed_team=$(codesign -dv --verbose=4 \
build/JLabTextQuickLook.app 2>&1 |
sed -n 's/^TeamIdentifier=//p')
[[ "$signed_team" == "$APPLE_TEAM_ID" ]] || {
echo "Signed TeamIdentifier $signed_team does not match APPLE_TEAM_ID" >&2
exit 1
}
./scripts/test.sh

- name: Notarize and staple application
Expand Down
8 changes: 5 additions & 3 deletions scripts/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,12 @@ for version in "${min_versions[@]}"; do
fail "expected macOS 13.0 deployment target, found $version"
done

bundle_version=$(/usr/libexec/PlistBuddy \
source_bundle_version=$(/usr/libexec/PlistBuddy \
-c 'Print :CFBundleShortVersionString' "$project_dir/App-Info.plist")
built_bundle_version=$(/usr/libexec/PlistBuddy \
-c 'Print :CFBundleShortVersionString' "$plist")
[[ "$bundle_version" == "1.3.0" ]] ||
fail "expected bundle version 1.3.0, found $bundle_version"
[[ "$built_bundle_version" == "$source_bundle_version" ]] ||
fail "source version $source_bundle_version does not match built version $built_bundle_version"

for extension in "${expected_extensions[@]}"; do
fixture="$project_dir/fixtures/example.$extension"
Expand Down
Loading