Remove what nothing uses, and keep one copy of the sample data - #268
Merged
Conversation
- `target/` was rust-analyzer's flycheck scratch, committed once and carrying another machine's absolute paths and a v3.1.0 build's warnings. Now ignored. - `public/SunAperture*.png` were replaced by the lucide Aperture glyph and referenced by nothing since. - `.gitmodules` declared `submodules/radiance_pipeline`, a directory that does not exist and has not for some time. - `binary_paths.json` held four empty tool paths, from before the tools were compiled into the app. Nothing reads it. - `extra/` held the lab's original `ldr-to-hdr.sh` and an R script, neither wired to anything. `stages.ts` cited `extra/ldr-to-hdr.sh:197` as the provenance of `pcomb -h`, which is load-bearing knowledge rather than trivia: it is the evidence the flag was inherited rather than chosen. The comment now says where the script was and that the history has it, so the reasoning survives the file. Verified nothing depended on any of it: 435 tests, lint clean, build clean, and no references left in the README, DEPLOYMENT.md, PRD.md or the workflows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The repository had two sets of sample calibration files: `example/`, which the README sends users to, and `e2e-tests/test/inputs/`, which the suites run. They had drifted, and not harmlessly. `example/fisheye_corr.cal` filled the region outside the lens circle with 1 where the fixture copy fills it with 0, while both carried the same comment saying "We also clear the region outside the r=[0,.5] circle to black". The copy users were pointed at contradicted its own documentation, and nothing exercised it, so nothing noticed. The fixture copy wins. The other three `example/` files were redundant under vaguer names: `response_function.rsp`, `vignetting.cal` and `calibration_factor.cal` are byte-identical to `Response_function.rsp`, `vignetting_f5d6.cal` and `CF_f5d6.cal`, whose names at least say which aperture they belong to. So the fixtures move to `example/` and everything reads from there: both end-to-end suites, the hdrgen benchmark, and the README. Sample data the tests exercise is sample data that stays correct. Also drops `e2e-tests/test/inputs/CR2/output.hdr`, a 66 MB pipeline *output* that had been committed inside the *inputs* directory and was referenced by nothing. The move costs no history: git stores content, so renaming reuses the same blobs. Verified: 435 unit tests, all three projects typecheck, lint clean, the benchmark's fixture resolution, and the full 18-frame browser pipeline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
adulbrich
added a commit
that referenced
this pull request
Aug 7, 2026
* chore: remove files nothing uses any more - `target/` was rust-analyzer's flycheck scratch, committed once and carrying another machine's absolute paths and a v3.1.0 build's warnings. Now ignored. - `public/SunAperture*.png` were replaced by the lucide Aperture glyph and referenced by nothing since. - `.gitmodules` declared `submodules/radiance_pipeline`, a directory that does not exist and has not for some time. - `binary_paths.json` held four empty tool paths, from before the tools were compiled into the app. Nothing reads it. - `extra/` held the lab's original `ldr-to-hdr.sh` and an R script, neither wired to anything. `stages.ts` cited `extra/ldr-to-hdr.sh:197` as the provenance of `pcomb -h`, which is load-bearing knowledge rather than trivia: it is the evidence the flag was inherited rather than chosen. The comment now says where the script was and that the history has it, so the reasoning survives the file. Verified nothing depended on any of it: 435 tests, lint clean, build clean, and no references left in the README, DEPLOYMENT.md, PRD.md or the workflows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore: one copy of the sample data, at example/, used by the tests The repository had two sets of sample calibration files: `example/`, which the README sends users to, and `e2e-tests/test/inputs/`, which the suites run. They had drifted, and not harmlessly. `example/fisheye_corr.cal` filled the region outside the lens circle with 1 where the fixture copy fills it with 0, while both carried the same comment saying "We also clear the region outside the r=[0,.5] circle to black". The copy users were pointed at contradicted its own documentation, and nothing exercised it, so nothing noticed. The fixture copy wins. The other three `example/` files were redundant under vaguer names: `response_function.rsp`, `vignetting.cal` and `calibration_factor.cal` are byte-identical to `Response_function.rsp`, `vignetting_f5d6.cal` and `CF_f5d6.cal`, whose names at least say which aperture they belong to. So the fixtures move to `example/` and everything reads from there: both end-to-end suites, the hdrgen benchmark, and the README. Sample data the tests exercise is sample data that stays correct. Also drops `e2e-tests/test/inputs/CR2/output.hdr`, a 66 MB pipeline *output* that had been committed inside the *inputs* directory and was referenced by nothing. The move costs no history: git stores content, so renaming reuses the same blobs. Verified: 435 unit tests, all three projects typecheck, lint clean, the benchmark's fixture resolution, and the full 18-frame browser pipeline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeeping after the 5.0.0 release. Two commits: removals, then the
example/consolidation.Removed, each verified unreferenced
target/.gitignore.public/SunAperture*.png.gitmodulessubmodules/radiance_pipeline, a directory that does not existbinary_paths.jsonextra/ldr-to-hdr.shand an R script, wired to nothinge2e-tests/test/inputs/CR2/output.hdrstages.tscitedextra/ldr-to-hdr.sh:197as the provenance ofpcomb -h. That is load-bearing rather than trivia — it is the evidence the flag was inherited rather than chosen, which is why #241 nearly removed it and why removing it broke the pipeline. The comment now says where the script was and that the history has it.One copy of the sample data
There were two sets of calibration files:
example/, which the README sends users to, ande2e-tests/test/inputs/, which the suites run. They had drifted, and not harmlessly.example/fisheye_corr.calfills the region outside the lens circle with 1; the fixture copy fills it with 0. Both carry the same comment:The copy users were pointed at contradicted its own documentation, and nothing exercised it, so nothing caught it. The fixture copy wins.
The other three
example/files were redundant under vaguer names —response_function.rsp,vignetting.calandcalibration_factor.calare byte-identical toResponse_function.rsp,vignetting_f5d6.calandCF_f5d6.cal, whose names at least say which aperture they belong to.So the fixtures move to
example/, and everything reads from there: both end-to-end suites, the hdrgen benchmark, and the README. Sample data the tests exercise is sample data that stays correct.The move costs no history — git stores content, so a rename reuses the same blobs.
Verification
435 unit tests, all three projects typecheck, lint clean, the benchmark's fixture resolution, and the full 18-frame browser pipeline end to end.
Note on ordering
A history rewrite is planned to purge ~800 MB of dead blobs (
dist/from the PyInstaller era,tmp/output*.hdr, the vendored hdrgen binaries, a committed installer). This should merge first, or it will need recreating against the rewritten history.🤖 Generated with Claude Code