Automated Resyntax fixes#816
Closed
resyntax-ci[bot] wants to merge 7 commits into
Closed
Conversation
These nested `for` loops can be replaced by a single `for*` loop.
This expression can be replaced with a simpler, equivalent `hash-update!` expression.
These list element variable definitions can be expressed more succinctly with `match-define`. Note that the suggested replacement raises an error if the list contains more elements than expected.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if` expression can be refactored to an equivalent expression using `and`.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
Using `cond` allows converting `let` to internal definitions, reducing nesting
rfindler
reviewed
Jul 19, 2026
| (format (string-constant cs-binder-count) end)))) | ||
| (cond | ||
| ;; assume this is a binder, show uses | ||
| #;(when (and color? (zero? start)) |
Member
There was a problem hiding this comment.
this comment was moved improperly
Member
|
Don't like how the comment was moved so I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 2 files.
let-to-definenested-for-to-for*list-element-definitions-to-match-defineand-let-to-condif-else-false-to-andhash-set!-ref-to-hash-update!when-expression-in-for-loop-to-when-keyword