Automated Resyntax fixes#813
Merged
Merged
Conversation
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
The `else`-`if` branch of this `cond` expression can be collapsed into the `cond` expression.
Nested `and` expressions can be flattened into a single, equivalent `and` expression.
This use of `printf` has no arguments other than the template string.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Use internal definitions instead of `let` expressions inside function arguments to reduce nesting.
This method chain made of nested `send` expressions can be written more clearly as a `send+` expression.
These list element variable definitions can be expressed more succinctly with `match-define`. Note that the suggested replacement raises an error if the list contains more elements than expected.
The `provide/contract` form is a legacy form made obsolete by `contract-out`.
Use `make-temporary-directory` to make directories instead of `make-temporary-file`.
rfindler
reviewed
Jul 19, 2026
| ;; the definitions and click execute with the empty buffer | ||
| (test:new-window defs-canvas) | ||
| (test:menu-select "Edit" "Select All") | ||
| (test:menu-select "Edit" "Delete") |
Member
There was a problem hiding this comment.
This is a giant blob where github's ability to highlight the changed portion of the diff is destroyed by the reindentation. I guess it is fine, tho, and since it is in test suites, I'll not stress over it. But it would be better if this wasn't happening.
rfindler
reviewed
Jul 19, 2026
| (define name-original (list-ref val 0)) | ||
| (define path-key (list-ref val 1)) | ||
| (define require-depth (list-ref val 2)) | ||
| (match-define (list name-original path-key require-depth) val) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 5 files.
let-to-definenested-and-to-flat-andif-let-to-condsend-chain-to-send+provide/contract-to-contract-outextract-lets-from-function-argumentscond-else-if-to-condlist-element-definitions-to-match-definemake-temporary-file-to-make-temporary-directoryprintf-to-displaycond-let-to-cond-define