refactor: complete internal command bus migration - #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
CommandApp.pending_commandsqueue, drain path, and synthetic drain testvalidation
cargo fmt --all -- --checkcargo checkcargo clippy --all-targets -- -D warningscargo build --all-targetscargo test --all-targets(756 passed)pending_commands; no productionClientMsgoutsideprotocol.rs; no command conversion/re-export seam; no protocol prompt type use outsideprotocol.rsbounded follow-ups
ClientMsgplus orphan legacy dtos and addresses the crate-widedead_codeallow; these unreferenced dto removals stay out of pr3attached=falsereconnect behavior and remote cwd when the mesh split lands; this pr does not change behavior without contract evidencerun_loopbranch is integration-heavy; existing producer coverage verifies ordered load plus subscribe commands and session-selection coverage verifies one load and one subscribe