fix: repair 16 failing tests across utility library - #276
Open
stooit wants to merge 1 commit into
Open
Conversation
…tion Implement truncate/remove/update/sortBy and fix off-by-one day rounding, over-restrictive email TLD and URL port rejection. All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across five source files. Suite now: 60 pass / 0 fail,
bunx tsc --noEmitexits 0. No test files modified, no dependencies added.Changes
src/calculator.ts—dividethrows on a zero divisor (was returningInfinity). Covers0and-0.src/string-utils.ts—wordCountsplits on/\s+/aftertrim()(collapses consecutive whitespace);truncateimplemented (was a stub): word-boundary truncation with"..."counted towardmaxLength, returns input unchanged when within limit.src/task-manager.ts—removedelegates toMap.delete;updateapplies present fields in place with per-key!== undefinedguards, returnsfalsefor unknown ids;sortByuses an exhaustive switch withRecordorder tables, sorts a copy (Map order preserved), relies on stable sort for equalcreatedAt.src/date-utils.ts—formatRelativeday count usesMath.round(Math.abs(diffHours) / 24), fixing the off-by-one (36h → "2 days ago").src/validator.ts—isEmailTLD quantifier relaxed{2,4}→{2,};isUrldrops theport === ""clause (protocol check and try/catch retained).Verification
bun test→ 60 pass / 0 failbunx tsc --noEmit→ exit 0Notes / assumptions
// BUG:/// TODO:comments cleared where fixed.sortByhas nodefault(union-guarded by TS);updatetreatsdescription: undefinedas a no-op;isUrlnow admits explicit ports (required by tests). None affect the test contract.