fix: implement missing utilities and fix edge-case bugs - #270
Open
stooit wants to merge 1 commit into
Open
Conversation
Fixes 16 failing tests across the utility library: - calculator: divide now throws on division by zero - string-utils: implement truncate (word-boundary + ellipsis); fix wordCount to handle consecutive whitespace - task-manager: implement remove, update, and sortBy (priority, createdAt) methods - date-utils: fix off-by-one in formatRelative (round vs floor on hours) - validator: allow long TLDs in isEmail; accept ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests in the utility library. The suite is now 60 pass / 0 fail, and
tsc --noEmitis clean. No test files were modified and no dependencies were added.Changes
src/calculator.ts) —dividenow throws on division by zero.src/string-utils.ts) — implementedtruncate(cuts at a word boundary, with"..."counting towardmaxLength, returns unchanged whenstr.length <= maxLength, and safely handles very short strings); fixedwordCountto collapse consecutive whitespace.src/task-manager.ts) — implementedremove,update, andsortBy(priority high>medium>low;createdAtoldest-first).src/date-utils.ts) — fixed off-by-one informatRelative(rounding hours instead of flooring).src/validator.ts) —isEmailaccepts long TLDs;isUrlaccepts URLs with a port.Verification
bun test→ 60 pass / 0 fail (70 assertions)bunx tsc --noEmit→ cleanReview notes
A review pass confirmed all fixes correct with no regressions. The flagged
isEmailregex was tested for ReDoS and found to be linear (not vulnerable), and CRLF-injection payloads are rejected. Non-blocking hardening suggestions were raised (SSRF docstring caveat onisUrl, stricter local-part rules onisEmail) but are out of scope here — the task was to fix only what the tests require.Assumptions